After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670176 - Warning when removing a child from a box if the chil has a refcount of 1
Warning when removing a child from a box if the chil has a refcount of 1
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-02-16 01:43 UTC by Lionel Landwerlin
Modified: 2012-03-18 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch v1 (1.29 KB, patch)
2012-02-16 01:43 UTC, Lionel Landwerlin 		accepted-commit_now Details | Review
gtkbox: avoid warning when removing a widget with refcount of 1 (1.34 KB, patch)
2012-03-18 19:41 UTC, Matthias Clasen 		committed Details | Review

Description Lionel Landwerlin 2012-02-16 01:43:00 UTC 
Created attachment 207715 [details] [review]
patch v1

Attached is patch preventing a warning on child removal on a box if that child has a refcount of exactly 1 (the box own the only reference).
Comment 1 Matthias Clasen 2012-02-16 02:32:03 UTC 
Review of attachment 207715 [details] [review]:

Looks right
Comment 2 Matthias Clasen 2012-03-18 19:40:56 UTC 
The following fix has been pushed:
adf36e2 gtkbox: avoid warning when removing a widget with refcount of 1
Comment 3 Matthias Clasen 2012-03-18 19:41:02 UTC 
Created attachment 210059 [details] [review]
gtkbox: avoid warning when removing a widget with refcount of 1

If gtkbox is the only object having a reference on one of its child
and that we try to remove it from its container, we endup having a
warning when disconnecting a signal after having unparented the
widget.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@linux.intel.com>