After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670174 - Don't take post-installation steps for saved domains
Don't take post-installation steps for saved domains
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-16 00:28 UTC by Zeeshan Ali
Modified: 2016-03-31 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't take post-installation steps for saved domains (953 bytes, patch)
2012-02-16 00:28 UTC, Zeeshan Ali 		reviewed Details | Review
Don't take post-installation steps for saved domains (1.06 KB, patch)
2012-02-18 15:11 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-02-16 00:28:39 UTC 
Requires my libvirt-glib patch that is awaiting review.
Comment 1 Zeeshan Ali 2012-02-16 00:28:42 UTC 
Created attachment 207711 [details] [review]
Don't take post-installation steps for saved domains
Comment 2 Zeeshan Ali 2012-02-16 18:04:31 UTC 
(In reply to comment #0)
> Requires my libvirt-glib patch that is awaiting review.

The patch in question has been pushed to git master.
Comment 3 Marc-Andre Lureau 2012-02-18 14:40:28 UTC 
Review of attachment 207711 [details] [review]:

can you be more explicit as to why the post_install_setup () cannot be run when the VM is saved?
Comment 4 Zeeshan Ali 2012-02-18 14:45:42 UTC 
(In reply to comment #3)
> Review of attachment 207711 [details] [review]:
> 
> can you be more explicit as to why the post_install_setup () cannot be run when
> the VM is saved?

Saved domains are 'shutdown' as well so them being shutdown doesn't mean that first boot is done and its time to perform post install setup.
Comment 5 Marc-Andre Lureau 2012-02-18 14:55:30 UTC 
Can you add this comment to the commit message?

ack
Comment 6 Zeeshan Ali 2012-02-18 15:11:56 UTC 
Created attachment 207928 [details] [review]
Don't take post-installation steps for saved domains

Saved domains are stopped as well so them being stoppd doesn't mean that
first boot is done and its time to perform post install setup.
Comment 7 Marc-Andre Lureau 2012-02-18 15:13:47 UTC 
Review of attachment 207928 [details] [review]:

ack s/stoppd/stopped s/its/it's
Comment 8 Zeeshan Ali 2012-02-18 15:16:03 UTC 
Attachment 207928 [details] pushed as 665a706 - Don't take post-installation steps for saved domains