After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670150 - docDisplay: Remove "Recent Items" search provider
docDisplay: Remove "Recent Items" search provider
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jasper St. Pierre (not reading bugmail)
gnome-shell-maint
Depends on: 662453
Blocks:
 
 
Reported: 2012-02-15 17:03 UTC by Florian Müllner
Modified: 2012-08-27 01:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
docDisplay: Remove "Recent Items" search provider (22.29 KB, patch)
2012-02-15 17:03 UTC, Florian Müllner
committed Details | Review
st: Remove thumbnail functions from TextureCache (14.48 KB, patch)
2012-02-21 22:00 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2012-02-15 17:03:27 UTC
Once bug 662453 lands, there will be significant overlap between results provided by gnome-documents and the existing GtkRecent provider; kill the latter, even though the rest of finding+reminding applications are not ready yet ...
Comment 1 Florian Müllner 2012-02-15 17:03:34 UTC
Created attachment 207683 [details] [review]
docDisplay: Remove "Recent Items" search provider

Although not all "Finding and reminding" applications are ready
yet, the integration with gnome-documents' search results overlaps
enough with the "Recent Items" provider to justify its removal.
Comment 2 Milan Bouchet-Valat 2012-02-15 19:01:28 UTC
Can we ensure there won't be any regression regarding files that are not handled by gnome-documenst? Wouldn't it be possible to simply exclude files that are returned by the gnome-documents search provider, but still show the others?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-02-21 03:54:21 UTC
Review of attachment 207683 [details] [review]:

Aaahhh... fresh code removal, just what I love in the morning.

Additionally, if I'm reading this correctly, a large part of st-texture-cache related to loading recent thumbnails seems like it can be trashed too, since this was the last user. And that means that we don't have to depend on gnome-desktop (until we port to GnomeDesktop.WallClock)
Comment 4 Florian Müllner 2012-02-21 22:00:37 UTC
Created attachment 208168 [details] [review]
st: Remove thumbnail functions from TextureCache

They were only used by the recent item search, which has been removed.

Follow-up cleanup, fun stuff!
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-02-21 22:03:52 UTC
Review of attachment 208168 [details] [review]:

Yes please.
Comment 6 Florian Müllner 2012-02-21 22:07:34 UTC
Comment on attachment 207683 [details] [review]
docDisplay: Remove "Recent Items" search provider

Attachment 207683 [details] pushed as ac78a1e - docDisplay: Remove "Recent Items" search provider
Comment 7 Florian Müllner 2012-02-21 22:11:17 UTC
Attachment 208168 [details] pushed as 80eac73 - st: Remove thumbnail functions from TextureCache
Comment 8 lmeditato 2012-08-27 01:44:19 UTC
It appears that document search does not work at all in the Gnome Shell 3.4.1 Activities Search on Ubuntu or Fedora.

A number of people have pointed to this thread as a basis for problems with searching documents. For example, see https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/970686

Ubuntu and Fedora users have had six months without this functionality.