After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670094 - cmake/Windows fix
cmake/Windows fix
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2012-02-14 19:25 UTC by Marcin Wojdyr
Modified: 2012-02-16 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch that adds a single .strip() (1.03 KB, patch)
2012-02-15 17:51 UTC, Marcin Wojdyr
committed Details | Review

Description Marcin Wojdyr 2012-02-14 19:25:49 UTC
Hi,
if there are two spaces in make command (e.g. "make  -j2") it fails on Windows,
for a reason that I haven't investigated, with:
> make: *** empty string invalid as file name. 

A quick fix for cmake is to use .strip() as it is done in autotools.py.
See the patch below.

BTW, I'm trying to use jhbuild for non-gnome project. I've fixed a few Windows issues and there are still some problems to be addressed. Other patches are more than one line. Should I format them with git patch-format? (I'm just reading how it works)


diff --git a/jhbuild/modtypes/cmake.py b/jhbuild/modtypes/cmake.py
index d71b02b..6a4de06 100644
--- a/jhbuild/modtypes/cmake.py
+++ b/jhbuild/modtypes/cmake.py
@@ -81,7 +81,7 @@ class CMakeModule(Package, DownloadableModule):
             if ' -j' not in args:
                 arg = '-j %s' % (self.config.jobs, )
                 args = args + ' ' + arg
-        return self.eval_args(args)
+        return self.eval_args(args).strip()
 
     def skip_configure(self, buildscript, last_phase):
         return buildscript.config.nobuild
Comment 1 André Klapper 2012-02-15 10:21:02 UTC
Attaching patches as attachments is welcome so they can be found/indexed by Bugzilla query/search.
Comment 2 Marcin Wojdyr 2012-02-15 17:51:36 UTC
Created attachment 207685 [details] [review]
patch that adds a single .strip()
Comment 3 Colin Walters 2012-02-16 22:58:28 UTC
Review of attachment 207685 [details] [review]:

Ugh...gross =(  Just one of the many failures that will happen when manipulating subprocess commands as strings...

But if it helps you, let's get it in.