GNOME Bugzilla – Bug 670094
cmake/Windows fix
Last modified: 2012-02-16 22:59:26 UTC
Hi, if there are two spaces in make command (e.g. "make -j2") it fails on Windows, for a reason that I haven't investigated, with: > make: *** empty string invalid as file name. A quick fix for cmake is to use .strip() as it is done in autotools.py. See the patch below. BTW, I'm trying to use jhbuild for non-gnome project. I've fixed a few Windows issues and there are still some problems to be addressed. Other patches are more than one line. Should I format them with git patch-format? (I'm just reading how it works) diff --git a/jhbuild/modtypes/cmake.py b/jhbuild/modtypes/cmake.py index d71b02b..6a4de06 100644 --- a/jhbuild/modtypes/cmake.py +++ b/jhbuild/modtypes/cmake.py @@ -81,7 +81,7 @@ class CMakeModule(Package, DownloadableModule): if ' -j' not in args: arg = '-j %s' % (self.config.jobs, ) args = args + ' ' + arg - return self.eval_args(args) + return self.eval_args(args).strip() def skip_configure(self, buildscript, last_phase): return buildscript.config.nobuild
Attaching patches as attachments is welcome so they can be found/indexed by Bugzilla query/search.
Created attachment 207685 [details] [review] patch that adds a single .strip()
Review of attachment 207685 [details] [review]: Ugh...gross =( Just one of the many failures that will happen when manipulating subprocess commands as strings... But if it helps you, let's get it in.