After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670086 - screenshot: should have a parameter for including pointer
screenshot: should have a parameter for including pointer
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-14 16:55 UTC by Cosimo Cecchi
Modified: 2012-02-14 20:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot: Add include_cursor parameter (9.52 KB, patch)
2012-02-14 18:26 UTC, drago01 		committed Details | Review
screenshot: Split into separate file / class (34.53 KB, patch)
2012-02-14 19:33 UTC, drago01 		committed Details | Review

Description Cosimo Cecchi 2012-02-14 16:55:02 UTC 
The "whole desktop" and "window" methods of the Screenshot interface should have a flag to enable or disable inclusion of the mouse pointer in the image.
The area shot is not affected by this, since in that case the pointer is outside of the image area by definition.
Comment 1 drago01 2012-02-14 18:26:20 UTC 
Created attachment 207574 [details] [review]
screenshot: Add include_cursor parameter

Add a boolean parameter to Screenshot and ScreenshotWindow which draws the cursor on the screenshot when set
to true.

---

This patchs adds that.
Works similar as the recorder i.e grab using XFixes and draws on the 
cairo surface (actually stole parts of the code from there).
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-02-14 18:39:20 UTC 
Review of attachment 207574 [details] [review]:

Can we split out the screenshot stuff to a separate file first?
Comment 3 drago01 2012-02-14 19:33:55 UTC 
Created attachment 207581 [details] [review]
screenshot: Split into separate file / class

Slit the screenshot functionality from ShellGlobal into its own class.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-02-14 19:39:18 UTC 
Review of attachment 207581 [details] [review]:

"Slit the screenshot functionality"

Feeling depressed?

Looks fine, otherwise.
Comment 5 drago01 2012-02-14 20:08:55 UTC 
Attachment 207574 [details] pushed as b2ec340 - screenshot: Add include_cursor parameter
Attachment 207581 [details] pushed as 4516e4c - screenshot: Split into separate file / class