GNOME Bugzilla – Bug 670011
Logging file operations with Zeitgeist
Last modified: 2019-09-30 12:24:34 UTC
Hi, Would you be open to consider logging file operations (create, rename, move, copy, link, delete/trash) with Zeitgeist? I'm attaching a patch that shows what this could look like. Since it depends on libzeitgeist, I'd expect it to be optional (with some --enable-zeitgeist-logging flag).
Patch is missing.
Created attachment 207488 [details] [review] patch
We'll be testing this out in Ubuntu, a patched Nautilus has been uploaded to https://launchpad.net/~ubuntu-desktop/+archive/ppa . The relevant Ubuntu bug is https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/927544
Created attachment 214693 [details] [review] Patch demonstrating possible Zeitgeist integration I'm attaching the updated patch (with the code that is currently shipping in Ubuntu).
Comment on attachment 214693 [details] [review] Patch demonstrating possible Zeitgeist integration $:andre\> patch --no-backup-if-mismatch -p0 < aaaapatch patching file libnautilus-private/nautilus-file-operations.c Hunk #1 succeeded at 64 with fuzz 2. Hunk #2 succeeded at 194 (offset 3 lines). Hunk #3 succeeded at 2054 (offset 119 lines). Hunk #4 succeeded at 4756 with fuzz 1 (offset 194 lines). Hunk #5 succeeded at 5339 with fuzz 1 (offset 215 lines). Hunk #6 succeeded at 5696 with fuzz 1 (offset 242 lines). Hunk #7 succeeded at 6185 with fuzz 1 (offset 283 lines). patching file libnautilus-private/nautilus-file.c Hunk #1 succeeded at 90 (offset 2 lines). Hunk #2 FAILED at 1724. 1 out of 2 hunks FAILED -- saving rejects to file libnautilus-private/nautilus-file.c.rej patching file test/run-zeitgeist-test.sh patching file test/test-nautilus-zeitgeist.c Hence setting 'needs-rework' as patch does not apply cleanly against git master.