GNOME Bugzilla – Bug 670003
wizard: Present OS logos
Last modified: 2016-03-31 13:58:12 UTC
If OS in question has a logo, use it to represent it at the 'Source' and 'Preparation' pages. Because of legal implications we (or libosinfo) can not ship the logos so we have to download it on the fly. Having said that, we keep logos cached on disk so Boxes only downloads logo for each OS once.
Created attachment 207472 [details] [review] wizard: Present OS logos If OS in question has a logo, use it to represent it at the 'Source' and 'Preparation' pages. Because of legal implications we (or libosinfo) can not ship the logos so we have to download it on the fly. Having said that, we keep logos cached on disk so Boxes only downloads logo for each OS once.
Created attachment 207500 [details] [review] wizard: Present OS logos If OS in question has a logo, use it to represent it at the 'Source' and 'Preparation' pages. Because of legal implications we (or libosinfo) can not ship the logos so we have to download it on the fly. Having said that, we keep logos cached on disk so Boxes only downloads logo for each OS once.
Created attachment 207602 [details] [review] wizard: Present OS logos If OS in question has a logo, use it to represent it at the 'Source' and 'Preparation' pages. Because of legal implications we (or libosinfo) can not ship the logos so we have to download it on the fly. Having said that, we keep logos cached on disk so Boxes only downloads logo for each OS once.
Created attachment 207967 [details] [review] wizard: Present OS logos Same patch but with some changes: * Rebased on top of git master. * As per the advice from Karen Sandler: * Explicitly specify the vendors of products. * Added trademark disclaimer notice. Still requires pending patches to libosinfo and looks like this: http://static.fi/~zeenix/tmp/boxes-small-iso-icons+logos.png (same URL).
For the record, the libosinfo patches are unfortunately blocking on discussions with fedora-legal ( http://lists.fedoraproject.org/pipermail/legal/2012-February/001828.html )
(In reply to comment #5) > For the record, the libosinfo patches are unfortunately blocking on discussions > with fedora-legal ( > http://lists.fedoraproject.org/pipermail/legal/2012-February/001828.html ) I expect them to say pretty much this: http://lists.fedoraproject.org/pipermail/legal/2011-April/001615.html but you never know so I'll wait. :) Keeping in mind the background of Karen Sandler in this area I trust her opinion and she basically said that although there are never any guarantees that you can defend your case in court, you can try you best to play it safe and thats what I'm trying to do with this new patch. The libosinfo decision is in Daniel's hands and while we can't force him to accept my patches, we can always move some of the code to Boxes when there is no other choice. In this case, we'll not need a lot of code, just a small dictionary.
Although very unlikely but just in case we are very lucky and get the legal matters sorted out today, I would like to get this into to today's release so we don't need to request freeze break for this essential (IMO) feature so it would be nice to already get a review of the technical and other non-legal aspects of this patch.
Created attachment 208177 [details] [review] wizard: Present OS logos If we have the logo for an OS, use it to represent it at the 'Source' and 'Preparation' pages. Because of legal implications we must get explicit permissions from each OS vendor to use and ship their logo. Thanks to Karen Sandler and Fedora legal for prompt action on prividing detailed but clear advice on usage of trademarks and logos. The following email nicely summarizes the whole issue with trademark usage: http://lists.fedoraproject.org/pipermail/advisory-board/2012-February/011360.html Currently we have Ubuntu and Debian logos. Canonical has already given us explicit permission and Debian's logo policy/licensing seems too liberal to require any permission: http://www.debian.org/logos/ Hopefully we'll soon have the permission to use Fedora and Red Hat logos too. If someone can tell me who and how to contact for Windows logos, do let me know please.
Created attachment 208224 [details] [review] wizard: Present OS logos If we have the logo for an OS, use it to represent it at the 'Source' and 'Preparation' pages. Because of legal implications we must get explicit permissions from each OS vendor to use and ship their logo. Thanks to Karen Sandler and Fedora legal for prompt action on prividing detailed but clear advice on usage of trademarks and logos. The following email nicely summarizes the whole issue with trademark usage: http://lists.fedoraproject.org/pipermail/advisory-board/2012-February/011360.html Currently we have Debian, Fedora and Ubuntu logos. We have been given explicit permission for each logo by their respective trademark owners except for Debian's, for which its policy seems too liberal to require any permission: http://www.debian.org/logos/ Hopefully we'll soon have the permission to use Red Hat logo too. If someone can tell me who and how to contact for Windows logos, do let me know please.
Review of attachment 208224 [details] [review]: ack
Attachment 208224 [details] pushed as b1810a7 - wizard: Present OS logos
Created attachment 208286 [details] [review] openSUSE Logo added as a patch
Review of attachment 208286 [details] [review]: Appreciate that your first patch is already in the right format. Just one minor nitpick about format: It is preferred to keep the short log less than 50 characters (if possible). Details could be provided in the description of course. ::: data/icons/Makefile.am @@ +30,3 @@ debianbuzz.svg \ fedora1.svg \ + opensuse.svg \ the name of the file (minus the extension) needs to be the same as the short-id of the most basic/oldest version of the OS in libosinfo db. In this case: opensuse102.
Comment on attachment 208286 [details] [review] openSUSE Logo added as a patch A modified version of this patch (along with following patches you provided through email) have been committed to git master.