GNOME Bugzilla – Bug 669921
Return expected type from handleDragOver for Activities button actors
Last modified: 2012-02-12 19:27:47 UTC
Currently they return void instead of something meaningful, e.g. DND.DragMotionResult.CONTINUE. This was unnoticed because none of the ancestors of the Activities button actors do any drag handling. The only visible issue are JS errors generated when dragging, for example, a window thumbnail over the button, because the cursor cannot be set.
Created attachment 207385 [details] [review] Return expected type from handleDragOver for Activities button actors
Review of attachment 207385 [details] [review]: Looks good, minor nitpick there is no such thing as "return void" in js they actually return undefined.
Created attachment 207406 [details] [review] Return expected type from handleDragOver for Activities button actors Currently they return 'undefined' instead of something meaningful, e.g. DND.DragMotionResult.CONTINUE. This was unnoticed because none of the ancestors of the Activities button actors do any drag handling. The only visible issue are JS errors generated when dragging, for example, a window thumbnail over the button, because the cursor cannot be set.
Attachment 207406 [details] pushed as eab4f4c - Return expected type from handleDragOver for Activities button actors