After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669835 - Make inspector handling real-world compliant
Make inspector handling real-world compliant
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-10 20:49 UTC by Gustavo Noronha (kov)
Modified: 2012-02-19 16:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed fix (3.71 KB, patch)
2012-02-10 20:53 UTC, Gustavo Noronha (kov) 		committed Details | Review

Description Gustavo Noronha (kov) 2012-02-10 20:49:56 UTC 
As things stand, reusing the inspector web view does not work, and we don't currently have a way of making the inspector remember whether it should start docked or not (that may change if we fix the inspector settings handling to use gsettings again). The patch I'll attach, following the fixes that went into WebKit recently makes the inspector usable and robust again in Epiphany.
Comment 1 Gustavo Noronha (kov) 2012-02-10 20:53:23 UTC 
Created attachment 207293 [details] [review]
proposed fix
Comment 2 Gustavo Noronha (kov) 2012-02-10 20:55:35 UTC 
Pff. the commit message is this one, actually:

    Make inspector handling real-world compliant
    
    Destroy and recreate the inspector's WebView instead of reusing it,
    and make it always start windowed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=669835
Comment 3 Xan Lopez 2012-02-19 09:47:33 UTC 
Review of attachment 207293 [details] [review]:

Looks good with the right commit message :)
Comment 4 Gustavo Noronha (kov) 2012-02-19 16:23:37 UTC 
befd8e788df39ba95b0936d1f728c07e8901dacf

Thanks =)