After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669809 - [PATCH] Fix a possible memory leak in _gedit_document_check_externally_modified()
[PATCH] Fix a possible memory leak in _gedit_document_check_externally_modifi...
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.3.x
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-10 15:07 UTC by Daniel Trebbien
Modified: 2012-02-10 17:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (1.03 KB, patch)
2012-02-10 15:07 UTC, Daniel Trebbien 		reviewed Details | Review

Description Daniel Trebbien 2012-02-10 15:07:37 UTC 
Created attachment 207261 [details] [review]
Fix

In _gedit_document_check_externally_modified(), `info` might not be unrefed.
Comment 1 Ignacio Casal Quinteiro (nacho) 2012-02-10 15:16:08 UTC 
Review of attachment 207261 [details] [review]:

Good catch. Just a minor inline comment.

::: gedit/gedit-document.c
@@ +1385,2 @@
 			g_file_info_get_modification_time (info, &timeval);
+

why the extra line?
Comment 2 Paolo Borelli 2012-02-10 17:19:50 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.