After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669797 - gvfs now lists its fuse mounts
gvfs now lists its fuse mounts
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-02-10 10:01 UTC by Vincent Untz
Modified: 2012-03-16 17:59 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4


Attachments
GIO patch (1.62 KB, patch)
2012-02-22 18:15 UTC, Tomas Bzatek
none Details | Review
GIO patch (1.83 KB, patch)
2012-02-23 18:11 UTC, Tomas Bzatek
committed Details | Review

Description Vincent Untz 2012-02-10 10:01:37 UTC
In the nautilus sidebar, I now see a gvfs item where I can access the gvfs mounts. It looks like the FUSE mount that gvfs uses.

And indeed:

$ gvfs-mount --list
Drive(0): Disque dur 160 GB
  Type: GProxyDrive (GProxyVolumeMonitorGdu)
  Volume(0): Système de fichiers 124 GB
    Type: GProxyVolume (GProxyVolumeMonitorGdu)
    Mount(0): Système de fichiers 124 GB -> file:///home
      Type: GProxyMount (GProxyVolumeMonitorGdu)
Drive(1): Lecteur CD/DVD
  Type: GProxyDrive (GProxyVolumeMonitorGdu)
Mount(0): gvfs -> file:///run/user/vuntz/gvfs
  Type: GProxyMount (GProxyVolumeMonitorGdu)

I'm not sure if this used to be hidden in nautilus before, or if gvfs was automagically hiding it before, though.

(GNOME 3.3.5)
Comment 1 Tomas Bzatek 2012-02-21 16:12:38 UTC
This has been fixed recently in the reopened bug 646391

*** This bug has been marked as a duplicate of bug 646391 ***
Comment 2 Vincent Untz 2012-02-21 16:39:08 UTC
Reopening: this is fixed in the udisks2 volume monitor, but not in the gdu one.
Comment 3 Tomas Bzatek 2012-02-21 16:43:03 UTC
Oh, I see it now:

(In reply to comment #0)
> Mount(0): gvfs -> file:///run/user/vuntz/gvfs
>   Type: GProxyMount (GProxyVolumeMonitorGdu)

Other volume monitors need to be updated after the /run has actually became used.
Comment 4 David Zeuthen (not reading bugmail) 2012-02-21 19:57:12 UTC
(In reply to comment #3)
> Oh, I see it now:
> 
> (In reply to comment #0)
> > Mount(0): gvfs -> file:///run/user/vuntz/gvfs
> >   Type: GProxyMount (GProxyVolumeMonitorGdu)
> 
> Other volume monitors need to be updated after the /run has actually became
> used.

The gdu one is, I believe, fixed by changing

 g_unix_is_mount_path_system_internal()

to only show mounts in $XDG_RUNTIME_DIR/media and not all of $XDG_RUNTIME_DIR. You basically want to modify what I added with this commit

 http://git.gnome.org/browse/glib/commit/?id=428f49b9c8d56ae18398d4bb33c70c80eda1d21d

HTH.
Comment 5 Tomas Bzatek 2012-02-22 18:15:22 UTC
Created attachment 208210 [details] [review]
GIO patch

Right, thanks for bringing the glib commit into my eyes. The GIO code should be made in sync with recent changes in gvfs.
Comment 6 David Zeuthen (not reading bugmail) 2012-02-22 22:17:55 UTC
OK, we actually changed today how udisks works and instead of using $XDG_RUNTIME_DIR/media (= /run/user/$USER/media) we are now using /run/media/$USER. We had to do this because of potential security problems having udisksd manage directories in $XDG_RUNTIME_DIR/media.

So I just updated udisks2 to do this

http://git.gnome.org/browse/gvfs/commit/?id=6307d017a12642e71ba2f04e82fc3781425a3eb6

My suggestion is still to make g_unix_mount_guess_should_display() behave like this - suggest to just copy the check the commit above. Thanks.
Comment 7 Tomas Bzatek 2012-02-23 18:11:06 UTC
Created attachment 208292 [details] [review]
GIO patch

Corrected patch with the new path reflected. It's untested however since my rawhide system is unoperable at the moment. But I shamelessly copied David's code and checked it twice.
Comment 8 Tomas Bzatek 2012-03-16 17:58:56 UTC
Committed to master:

commit f3fca56b7ef94e70e78597afca69b157e07cd339
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Fri Mar 16 18:54:09 2012 +0100

    gio: Only show mounts in /run/media/$USER
    
    And reflect the recent changes + sync with gvfs+udisks2 rules.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=669797