After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669787 - [PATCH] port from CK to systemd-logind
[PATCH] port from CK to systemd-logind
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: daemon
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks: systemd
 
 
Reported: 2012-02-10 04:57 UTC by Lennart Poettering
Modified: 2012-02-22 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
port gnome-screensaver to systemd-logind (14.34 KB, patch)
2012-02-10 04:57 UTC, Lennart Poettering
none Details | Review
port gnome-screensaver to systemd-logind (14.39 KB, patch)
2012-02-10 07:14 UTC, Matthias Clasen
committed Details | Review
configure: fix --with-systemd=auto (1.91 KB, patch)
2012-02-10 23:49 UTC, Ray Strode [halfline]
committed Details | Review

Description Lennart Poettering 2012-02-10 04:57:33 UTC
Created attachment 207231 [details] [review]
port gnome-screensaver to systemd-logind

The attached ports gnome-screensaver from ConsoleKit to systemd-logind which has obsoleted the former. This is necessary to make gnome-screensaver work nicely on distributions such as Fedora.
Comment 1 Matthias Clasen 2012-02-10 07:14:46 UTC
The following fix has been pushed:
6bb98e9 port gnome-screensaver to systemd-logind
Comment 2 Matthias Clasen 2012-02-10 07:14:48 UTC
Created attachment 207235 [details] [review]
port gnome-screensaver to systemd-logind

On Fedora and other distributions ConsoleKit is being replaced by
systemd-logind. Accordingly, all tools previously talking to CK need to
talk to systemd-logind instead.

This patch will dynamically fall back to CK if systemd is not found,
thus being nice to Debian style distributions which want to support
systemd and non-systemd systems with the same packages.
Comment 3 Allison Karlitskaya (desrt) 2012-02-10 21:57:13 UTC
reopening this.

jhbuild is currently failing like so:

checking for SYSTEMD... no
configure: error: Package requirements (libsystemd-login libsystemd-daemon) were not met:

No package 'libsystemd-login' found
No package 'libsystemd-daemon' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables SYSTEMD_CFLAGS
and SYSTEMD_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.



I think the fallback is not working as intended?
Comment 4 Ray Strode [halfline] 2012-02-10 23:47:31 UTC
looks like --with-systemd=auto is broken
Comment 5 Ray Strode [halfline] 2012-02-10 23:49:49 UTC
The following fix has been pushed:
5c692be configure: fix --with-systemd=auto
Comment 6 Ray Strode [halfline] 2012-02-10 23:49:52 UTC
Created attachment 207302 [details] [review]
configure: fix --with-systemd=auto

The logic wasn't quite complicated enough to work.