After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669766 - tests: rename test files to avoid duplicates
tests: rename test files to avoid duplicates
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-09 18:37 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-02-10 20:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: rename files to avoid duplicate names (4.15 KB, patch)
2012-02-09 18:37 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review
tests: sync vim/emacs modeline comments (1.65 KB, patch)
2012-02-09 18:37 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review
tests: terminate noinst_PROGRAMS with NULL (780 bytes, patch)
2012-02-09 18:40 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-09 18:37:02 UTC 
plus, some miscellaneous cleanup
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 18:37:03 UTC 
Created attachment 207207 [details] [review]
tests: rename files to avoid duplicate names

Append -test to .c files in tests/ to avoid duplicating filenames in the
repository.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 18:37:06 UTC 
Created attachment 207208 [details] [review]
tests: sync vim/emacs modeline comments
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 18:40:53 UTC 
Created attachment 207209 [details] [review]
tests: terminate noinst_PROGRAMS with NULL

To avoid trivial line changes, ironically.
Comment 4 Xan Lopez 2012-02-10 10:23:59 UTC 
Review of attachment 207207 [details] [review]:

The patch does not seem to do any rename, but I guess it's bugzilla or git being silly...
Comment 5 Xan Lopez 2012-02-10 10:25:18 UTC 
Review of attachment 207208 [details] [review]:

::: tests/ephy-embed-single-test.c
@@ +1,2 @@
 /* vim: set sw=2 ts=2 sts=2 et: */
+/* -*- Mode: C; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */

Seriously, moving Emacs to second? ಠ_ಠ
Comment 6 Xan Lopez 2012-02-10 10:25:52 UTC 
Review of attachment 207209 [details] [review]:

OK.
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2012-02-10 20:01:15 UTC 
Done!

Attachment 207207 [details] pushed as afcf0e1 - tests: rename files to avoid duplicate names
Attachment 207208 [details] pushed as ae6c80b - tests: sync vim/emacs modeline comments
Attachment 207209 [details] pushed as a32a038 - tests: terminate noinst_PROGRAMS with NULL