After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669740 - Application menu is broken for private instances
Application menu is broken for private instances
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-09 11:21 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-02-09 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ephy-shell: set the application menu for private mode (2.36 KB, patch)
2012-02-09 11:59 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-09 11:21:32 UTC
SSIA.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 11:44:45 UTC
I suspect this could be GNOME Shell, not us.

I just tried the patch with metacity. The application menu is embedded in the window as "Web" and has all the items. This works for private and non private instances.

A quick look at GNOME Shell's code in js/ui/panel.js shows that it is either the model as mined by the Shell or the fallback Quit menu.

Since we are seeing the empty menu, it is trying to use the mined model.
We have to find why it is breaking for our case.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 11:59:51 UTC
Created attachment 207182 [details] [review]
ephy-shell: set the application menu for private mode
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 12:10:40 UTC
(In reply to comment #2)
> Created an attachment (id=207182) [details] [review]
> ephy-shell: set the application menu for private mode

Reference patch. Apply this and:
- run epiphany -p => empty application menu.
- run epiphany, don't close it, then epiphany -p => application menu on both

I'm suspecting this is because of G_APPLICATION_NON_UNIQUE not being handled correctly by GNOME Shell.

d-feet shows that regular Epiphany registers in DBus with /org/gnome/Epiphany and the org.gtk.Actions interface. Private mode doesn't, because of NON_UNIQUE.

This results in the object path for menu existing, but not the org.gtk.Actions interface needed to fill such menu.

Not sure how to do this. Should ask the people that do know.
Comment 4 Xan Lopez 2012-02-09 14:33:02 UTC
I've pushed the obvious fix for this to master. It's still broken because non-unique apps are not in the bus, see bug #647986.