After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669705 - GtkBuilder signal connect override is buggy
GtkBuilder signal connect override is buggy
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-08 21:03 UTC by Allison Karlitskaya (desrt)
Modified: 2012-02-08 21:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix GtkBuilder signal connection 'after' logic (1.06 KB, patch)
2012-02-08 21:10 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
test (1.64 KB, patch)
2012-02-08 21:32 UTC, Paolo Borelli 		none Details | Review

Description Allison Karlitskaya (desrt) 2012-02-08 21:03:52 UTC 
http://git.gnome.org/browse/pygobject/commit/?id=9f34d120845d936b04546a5cea599ec67e9181a7

This introduces the following obviously buggy code:

+ after = flags or GObject.ConnectFlags.AFTER

'after' is used as a boolean later.  It's pretty clear that it will always be true.
Comment 1 Allison Karlitskaya (desrt) 2012-02-08 21:10:08 UTC 
Created attachment 207140 [details] [review]
fix GtkBuilder signal connection 'after' logic

All GtkBuilder signals are presently being connected 'after', ignoring
what is specified in the builder XML.  This is due to an obvious logic
error.
Comment 2 Paolo Borelli 2012-02-08 21:32:31 UTC 
Created attachment 207142 [details] [review]
test
Comment 3 Paolo Borelli 2012-02-08 21:33:20 UTC 
Review of attachment 207140 [details] [review]:

With the patch the unit test passes.

Push it! Then I will push the test
Comment 4 Allison Karlitskaya (desrt) 2012-02-08 21:35:48 UTC 
Comment on attachment 207140 [details] [review]
fix GtkBuilder signal connection 'after' logic

Attachment 207140 [details] pushed as 671f9b0 - fix GtkBuilder signal connection 'after' logic
Comment 5 Paolo Borelli 2012-02-08 21:39:10 UTC 
Pushed also the test. Thanks!