After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669700 - Application mode should fail if profile_directory is invalid
Application mode should fail if profile_directory is invalid
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-08 20:07 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-03-10 19:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-main: run app mode only with a existing dir (1.12 KB, patch)
2012-03-01 21:47 UTC, Diego Escalante Urrelo (not reading bugmail) 		needs-work Details | Review
ephy-main: run app mode only with a existing dir (850 bytes, patch)
2012-03-03 05:10 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-08 20:07:12 UTC 
Instead of silently running like a regular epiphany.

Should it die? Pop a dialog?
Comment 1 Xan Lopez 2012-02-22 14:37:26 UTC 
Just die and print an error.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-03-01 21:47:22 UTC 
Created attachment 208821 [details] [review]
ephy-main: run app mode only with a existing dir
Comment 3 Xan Lopez 2012-03-02 19:01:30 UTC 
Review of attachment 208821 [details] [review]:

Why here? Just do it in the existing else if (application mode) { ...
And g_file_test seems simpler than what you do.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2012-03-03 05:10:44 UTC 
Created attachment 208893 [details] [review]
ephy-main: run app mode only with a existing dir

=
In the existing else if, ephy_file_helpers_init() has already ran and
has created the directory if it was non-existant. So this check would
always be TRUE. 

Re: the glib API. Yeah, shame on me.
Comment 5 Xan Lopez 2012-03-09 13:38:06 UTC 
Review of attachment 208893 [details] [review]:

OK.
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2012-03-10 19:05:37 UTC 
Attachment 208893 [details] pushed as b0b25d7 - ephy-main: run app mode only with a existing dir