After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669695 - ContactInfo: always escape IRC channel names in markup
ContactInfo: always escape IRC channel names in markup
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-08 17:51 UTC by Will Thompson
Modified: 2012-02-10 11:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ContactInfo: always escape IRC channel names in markup (1.19 KB, patch)
2012-02-08 17:51 UTC, Will Thompson 		committed Details | Review

Description Will Thompson 2012-02-08 17:51:07 UTC 
I noticed that channel names containing ampersands broke the IRC channel list in the contact info dialog. Whoops.
Comment 1 Will Thompson 2012-02-08 17:51:08 UTC 
Created attachment 207131 [details] [review]
ContactInfo: always escape IRC channel names in markup

For some reason, I chose to escape the channel name for the contents of
the href='' attribute but not in the body of the tag. Thus, channel
names like "#r&d" made Pango refuse to coöperate.
Comment 2 Guillaume Desmottes 2012-02-10 11:03:27 UTC 
Review of attachment 207131 [details] [review]:

++
Comment 3 Will Thompson 2012-02-10 11:14:48 UTC 
Attachment 207131 [details] pushed as 91d3734 - ContactInfo: always escape IRC channel names in markup