After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669633 - The application menu won't show translated messages.
The application menu won't show translated messages.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: I18N
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 669638
Blocks:
 
 
Reported: 2012-02-08 07:17 UTC by Jiro Matsuzawa
Modified: 2012-02-08 09:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch for this bug (979 bytes, patch)
2012-02-08 07:20 UTC, Jiro Matsuzawa 		none Details | Review

Description Jiro Matsuzawa 2012-02-08 07:17:36 UTC 
The application menu won't show translated messages.
It shows the English messages.

[Steps to reproduce]
1. Set locale variables (ex: $ export LANG=ja_JP.utf8)
2. Run Epiphany on the GNOME Shell
3. Click the the application icon on the top bar to open the application menu.
4. The menu won't show the translated strings (it shows the English strings).

[Cause]
That is because the translation domain of the GtkBuilder of the app-menu is not set.
You should call gtk_builder_set_translation_domain() after you create the builder.
Comment 1 Jiro Matsuzawa 2012-02-08 07:20:55 UTC 
Created attachment 207058 [details] [review]
a patch for this bug

Set the translation domain of the buildoer of the application menu.
Please review it.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 08:00:33 UTC 
Review of attachment 207058 [details] [review]:

This indeed solves the problem.

But, why is it that GtkApplication is unaware of its translation_domain?
Other menus and UI elements get their translations properly and we are never calling this GtkBuilder API.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 08:40:24 UTC 
Did research. Wrote gigaenormous comment.

Ended up fixing the bugs instead:

- Bug 669638 - gtkbuilder-menus: translation-domain can be NULL
- Bug 669636 - gtkactiongroup: clarify set_translation_domain docs

So it is a GTK+ bug, no need to explicitely set the translation-domain!
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2012-02-08 09:42:10 UTC 
GTK+ bugs fixed, this works fine now! Thanks Jiro!