After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669587 - Use new documentation infrastructure
Use new documentation infrastructure
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-07 16:57 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-02-08 12:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use new documentation infrastructure (1.91 KB, patch)
2012-02-07 16:57 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Use new documentation infraestructure.v2 (2.38 KB, patch)
2012-02-07 17:41 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2012-02-07 16:57:48 UTC 
Created attachment 206999 [details] [review]
Use new documentation infrastructure

Patch following
Comment 1 Ignacio Casal Quinteiro (nacho) 2012-02-07 17:35:48 UTC 
Review of attachment 206999 [details] [review]:

Just one question inline. If you are sure about it feel free to push

::: help/Makefile.am
@@ -68,3 @@
 	index.page
 
-DOC_LINGUAS = ar bg ca cs da de el es eu fi fr gl hu it ja ko oc pt_BR ru sl sv th uk zh_CN zh_HK zh_TW

how is this managed now? autodetected?
Comment 2 Javier Jardón (IRC: jjardon) 2012-02-07 17:41:34 UTC 
Created attachment 207006 [details] [review]
Use new documentation infraestructure.v2
Comment 3 Javier Jardón (IRC: jjardon) 2012-02-07 20:37:28 UTC 
Comment on attachment 207006 [details] [review]
Use new documentation infraestructure.v2

commit a9607074f4f61677f28cd186b1d817db2f3369d9
Comment 4 Javier Jardón (IRC: jjardon) 2012-02-07 20:38:03 UTC 
Committed after ACK of pbor on IRC
Comment 5 Shaun McCance 2012-02-07 20:39:49 UTC 
HELP_LINGUAS is the right thing to use now. I don't believe in auto-detecting. It leads to stuff being in tarballs that isn't in git.
Comment 6 Paolo Borelli 2012-02-07 20:52:10 UTC 
(In reply to comment #4)
> Committed after ACK of pbor on IRC

Well, I hacked conditionally to verifying translations support was working.

Please fix the patch according to Shaun's comment.
Comment 7 Jeremy Bicha 2012-02-07 22:40:12 UTC 
Also, I believe it needs to be help:%s/%s with a / instead of a ?

I made that mistake too a few months ago.
Comment 8 Javier Jardón (IRC: jjardon) 2012-02-08 12:37:46 UTC 
Sorry Paolo, fixed in commit 4ff6ec399f16763bb61455ff8d6be8c8ecf87ca4 , also with the Jeremy comment