After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669572 - aisleriot 3.3.2 tarball is broken
aisleriot 3.3.2 tarball is broken
Status: RESOLVED FIXED
Product: yelp-tools
Classification: Core
Component: yelp.m4
git master
Other Linux
: Normal major
: ---
Assigned To: Yelp maintainers
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-07 13:29 UTC by Vincent Untz
Modified: 2012-03-27 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
yelp.m4: Dist all linguas (905 bytes, patch)
2012-02-07 14:29 UTC, Christian Persch 		none Details | Review

Description Vincent Untz 2012-02-07 13:29:17 UTC 
$ grep HELP_LINGUAS aisleriot-3.3.2/help/Makefile.am 
HELP_LINGUAS = ca de el en_GB es eu fr gl oc ru sl sr sr@latin sv zh_CN
$ ls aisleriot-3.3.2/help/
C/  de/  en_GB/  fr/  Makefile.am  Makefile.in  sol.6

The Makefile references translations that are not in the tarball, which leads to build failures.
Comment 1 Christian Persch 2012-02-07 14:29:29 UTC 
This is a yelp-tools bug, reassigning.

In by build environmen, I have the LINGUAS env var set to a short list of languages I need to test, so not all the translations are installed, to save time when building, as well as saving installed space. While yelp-tools does take LINGUAS into account while building, it appears to _also_ use it when _dist'ing_, which it shouldn't.
Comment 2 Christian Persch 2012-02-07 14:29:40 UTC 
Created attachment 206986 [details] [review]
yelp.m4: Dist all linguas

The linguas to dist in the tarball must not take LINGUAS into account.
Comment 3 Christian Persch 2012-02-07 14:43:19 UTC 
Pushed to master after Shaun gave his ok on IRC.

Note sure yet if I will roll a new aisleriot tarball or wait until the 3.3.90.
Comment 4 Christian Persch 2012-03-26 18:40:34 UTC 
Reopening; there's more to be done.

Proposed patches at http://people.gnome.org/~chpe/patches/yelp.m4-dist.patch and http://people.gnome.org/~chpe/patches/yelp.m4-dist.patch2 . While I was at it, I made it *not* dist the merged .xml files and the stamp files.
Comment 5 Christian Persch 2012-03-27 14:14:24 UTC 
Fixed on master with commit http://git.gnome.org/browse/yelp-tools/commit/?id=13a179762334c49d2d50abc245cd27aec45ae919 .