After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669557 - Google backend doesn't properly go !readonly when the network comes online
Google backend doesn't properly go !readonly when the network comes online
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-02-07 11:11 UTC by Alexander Larsson
Modified: 2012-02-07 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix google contacts readonly status changes due to online changes (975 bytes, patch)
2012-02-07 11:11 UTC, Alexander Larsson 		accepted-commit_now Details | Review

Description Alexander Larsson 2012-02-07 11:11:18 UTC 
Created attachment 206970 [details] [review]
Fix google contacts readonly status changes due to online changes

The google contacts backend has another error similar to bug 658911, if it goes offline and then goes online it does request_auth(), but in the case of existing GOA authentication that will never recieve the authentication callback, so we never go !readonly.

I'm attaching a patch that fixes this, which also fixes an issue in the fix in bug 658911, where if its offline at startup it should not claim to be !readonly.
Comment 1 Milan Crha 2012-02-07 11:24:40 UTC 
Looks good, please commit.
Comment 2 Alexander Larsson 2012-02-07 11:39:17 UTC 
commited