After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669551 - Added error when not exporting any namespaces for GIR
Added error when not exporting any namespaces for GIR
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: GObject Introspection
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-07 10:26 UTC by jessevdk@gmail.com
Modified: 2012-02-08 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Added error when not exporting any namespaces for GIR (913 bytes, patch)
2012-02-07 10:26 UTC, jessevdk@gmail.com 		needs-work Details | Review
Added error when not exporting any namespaces for GIR (913 bytes, patch)
2012-02-08 08:35 UTC, jessevdk@gmail.com 		none Details | Review
Added error when not exporting any namespaces for GIR (912 bytes, patch)
2012-02-08 09:29 UTC, jessevdk@gmail.com 		committed Details | Review

Description jessevdk@gmail.com 2012-02-07 10:26:42 UTC 
GIR does not support exporting a file without any namespaces in it
Comment 1 jessevdk@gmail.com 2012-02-07 10:26:44 UTC 
Created attachment 206965 [details] [review]
Added error when not exporting any namespaces for GIR
Comment 2 Luca Bruno 2012-02-07 10:46:01 UTC 
Review of attachment 206965 [details] [review]:

Thanks for the patch.

::: codegen/valagirwriter.vala
@@ +191,3 @@
+
+		if (our_namespaces.size == 0)
+		{

This '{' must go on the line above.

@@ +192,3 @@
+		if (our_namespaces.size == 0)
+		{
+			Report.error (null, "Must export at least one namespace for GIR");

What about "No suitable namespace found to export for GIR" ?
Comment 3 jessevdk@gmail.com 2012-02-08 08:35:21 UTC 
Created attachment 207065 [details] [review]
Added error when not exporting any namespaces for GIR
Comment 4 Luca Bruno 2012-02-08 09:21:11 UTC 
Review of attachment 207065 [details] [review]:

It's apparently the same patch as above.
Comment 5 jessevdk@gmail.com 2012-02-08 09:29:40 UTC 
Created attachment 207072 [details] [review]
Added error when not exporting any namespaces for GIR
Comment 6 jessevdk@gmail.com 2012-02-08 09:30:14 UTC 
I'm having good times with git, take 3.
Comment 7 Luca Bruno 2012-02-08 09:35:53 UTC 
Review of attachment 207072 [details] [review]:

Thanks for the patch.
Comment 8 jessevdk@gmail.com 2012-02-08 10:08:07 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.