After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669489 - Change the color of the top panel's border
Change the color of the top panel's border
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-06 16:27 UTC by Evandro Giovanini
Modified: 2012-02-08 22:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
no border for top bar (2.12 KB, patch)
2012-02-06 18:11 UTC, Jakub Steiner 		needs-work Details | Review
Pardon, pardon! Fixed build issue. (2.12 KB, patch)
2012-02-06 23:36 UTC, Jakub Steiner 		none Details | Review
Third time's the charm. (2.55 KB, patch)
2012-02-06 23:43 UTC, Jakub Steiner 		committed Details | Review
panel: Simplify corner drawing (4.38 KB, patch)
2012-02-08 13:46 UTC, Florian Müllner 		committed Details | Review

Description Evandro Giovanini 2012-02-06 16:27:20 UTC 
The color of the border on the top panel is #536272. IMO this makes it stand out a little too much, specially if the user has a dark background applied.

I would suggest changing the color to #333333. This would also make it look similar to the border in the dash and workspace switcher.

The affected files are panel-border.svg and gnome-shell.css, making the change is very simple.
Comment 1 Allan Day 2012-02-06 17:24:58 UTC 
I toyed around with the idea of removing the border altogether recently. It makes the top bar appear much more like dead space rather than something that is overlaid.
Comment 2 Jakub Steiner 2012-02-06 18:11:27 UTC 
Created attachment 206924 [details] [review]
no border for top bar

I agree.
Comment 3 Florian Müllner 2012-02-06 18:33:47 UTC 
Review of attachment 206924 [details] [review]:

Patch doesn't build due to left-over reference to panel-border.svg in data/Makefile.am. Apart from that, do we want to remove the "app-icon-bottom-clip: 1px;" as well? Or is a black "border" intended in that case?
Comment 4 Jakub Steiner 2012-02-06 20:07:51 UTC 
I think the inner black border looks nice wrt to the app menu icon.
Comment 5 Florian Müllner 2012-02-06 20:13:59 UTC 
(In reply to comment #4)
> I think the inner black border looks nice wrt to the app menu icon.

OK, I was just wondering if it was an oversight; doesn't excuse you from fixing the Makefile though :p
Comment 6 Jakub Steiner 2012-02-06 23:36:27 UTC 
Created attachment 206943 [details] [review]
Pardon, pardon! Fixed build issue.
Comment 7 Florian Müllner 2012-02-06 23:39:45 UTC 
Wrong patch?
Comment 8 Jakub Steiner 2012-02-06 23:43:11 UTC 
Created attachment 206944 [details] [review]
Third time's the charm.
Comment 9 Florian Müllner 2012-02-06 23:50:53 UTC 
Review of attachment 206944 [details] [review]:

Yup - please replace the "bug #669489" reference by the full bugzilla URL before pushing
Comment 10 Florian Müllner 2012-02-08 13:46:11 UTC 
Created attachment 207098 [details] [review]
panel: Simplify corner drawing

With the panel border removed, it is no longer necessary to account
for it in the corner drawing code, so simplify the drawing code
a bit.

Removing -panel-corner-outer-border-width/color from the CSS results in a bunch of warnings (because we lookup those values using get_length() instead of lookup_length()) - rather than just fixing the warnings, remove support for those properties from the drawing code.
Comment 11 drago01 2012-02-08 22:28:11 UTC 
Review of attachment 207098 [details] [review]:

Looks good.
Comment 12 Florian Müllner 2012-02-08 22:41:43 UTC 
Attachment 206944 [details] pushed as 8b4c1a8 - theme: Remove border from top bar
Attachment 207098 [details] pushed as d1fc875 - panel: Simplify corner drawing