After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669393 - Distinguish between GArray and GPtrArray when cleaning up
Distinguish between GArray and GPtrArray when cleaning up
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
Git master
Other Linux
: Normal critical
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-05 11:08 UTC by Sebastian Pölsterl
Modified: 2012-02-06 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes this issue (4.33 KB, patch)
2012-02-05 11:08 UTC, Sebastian Pölsterl
none Details | Review

Description Sebastian Pölsterl 2012-02-05 11:08:02 UTC
Created attachment 206811 [details] [review]
Patch that fixes this issue

This fixes a crash in test_gi.TestGPtrArray and makes sure memory is free'd correctly. You'll need latest gobject-introspection from master for all tests to pass.
Comment 1 Martin Pitt 2012-02-06 14:03:48 UTC
I can reproduce the crash in the test suite, seems a recent glib changed some handling there. The crash was not introduced by any particular pygobject commit, I checked that with git bisect.

The patch looks fine to me, and I confirm that it fixes the crash. +1 from me.

Thank you for fixing this!
Comment 2 Martin Pitt 2012-02-06 14:11:04 UTC
Pushed.