GNOME Bugzilla – Bug 669365
rotate plugin docs say that 'angle' is in radians, yet seems to be in degrees
Last modified: 2012-02-09 18:42:52 UTC
The documentation (via gst-insepct) for the rotate plugin in -bad says that the angle paramters is in radians, however when i use it it seems to be in degrees. Firstly angle=45 produces a good 4͏5° rotated angle, and angle=30 shows the video rotated at 30͏°. angle=0.78 (0.78 radians is approximately 45͏°) shows the video only rotated by a little small amount, not 45͏°. I am using version 0.10.22-2ubuntu4 from ubuntu. Either the documentation or the code should be changed.
I see the same, and also the description is wrong: Description: Warps the picture into an arc shaped form Looks like the rotate plugin was based off the circle plugin and someone forgot to update the documentation strings.
Created attachment 206784 [details] [review] rotate: fix description string to match what the element does
Created attachment 206785 [details] [review] rotate: angle is in radians already, do not scale it Other plugins use radians, and the angle documentation says radians.
commit ddff93320dda8460c22fbe3cc0567b40fb4a0f31 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Sat Feb 4 22:06:57 2012 +0000 rotate: angle is in radians already, do not scale it Other plugins use radians, and the angle documentation says radians. https://bugzilla.gnome.org/show_bug.cgi?id=669365 commit e84bbcbeabece21849f45d51b6e0f7b766cfa4dd Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Sat Feb 4 22:06:12 2012 +0000 rotate: fix description string to match what the element does https://bugzilla.gnome.org/show_bug.cgi?id=669365