After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669331 - try to get gio tests working a little better on win32
try to get gio tests working a little better on win32
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-02-03 18:08 UTC by Dan Winship
Modified: 2012-08-06 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glocalfile: fix g_file_get_parse_name() on win32 (1.46 KB, patch)
2012-02-03 18:08 UTC, Dan Winship
none Details | Review
gio/tests/g-file.c: fix some path checks on win32 (3.86 KB, patch)
2012-02-03 18:08 UTC, Dan Winship
none Details | Review
gio/tests/file: skip the file monitor tests if using GPollFileMonitor (1.85 KB, patch)
2012-02-03 18:08 UTC, Dan Winship
none Details | Review
gicon: make g_icon_new_for_string() recognize win32 paths (920 bytes, patch)
2012-02-03 18:08 UTC, Dan Winship
none Details | Review
gio/tests/g-icon.c: fix some path checks on win32 (2.18 KB, patch)
2012-02-03 18:08 UTC, Dan Winship
none Details | Review

Description Dan Winship 2012-02-03 18:08:27 UTC
a lot of the gio tests fail on win32 for various reasons, often
path-related.

I'm not totally convinced about the correctness of any of these
patches.
Comment 1 Dan Winship 2012-02-03 18:08:28 UTC
Created attachment 206700 [details] [review]
glocalfile: fix g_file_get_parse_name() on win32

When getting the parse name for a file: URI on win32, we were not
translating "\" to "/", resulting in incorrect output.
Comment 2 Dan Winship 2012-02-03 18:08:31 UTC
Created attachment 206701 [details] [review]
gio/tests/g-file.c: fix some path checks on win32

Some of the tests needed to be modified to use G_DIR_SEPARATOR_S
rather than hardcoded "/"s.
Comment 3 Dan Winship 2012-02-03 18:08:34 UTC
Created attachment 206702 [details] [review]
gio/tests/file: skip the file monitor tests if using GPollFileMonitor

test_create_delete() assumes that if it creates a file and then
immediately deletes it, that the file monitor will notice this and
record it as a create followed by a delete. But that won't work with
GPollFileMonitor, which will just think nothing changed. So skip the
test in that case.
Comment 4 Dan Winship 2012-02-03 18:08:37 UTC
Created attachment 206703 [details] [review]
gicon: make g_icon_new_for_string() recognize win32 paths

(but for compatibility, make it still recognize unix paths on win32
too)
Comment 5 Dan Winship 2012-02-03 18:08:39 UTC
Created attachment 206704 [details] [review]
gio/tests/g-icon.c: fix some path checks on win32

Some of the tests needed to be modified to use G_DIR_SEPARATOR_S
rather than hardcoded "/"s.