After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669327 - totem --play doesn't resume playing
totem --play doesn't resume playing
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-03 17:14 UTC by Sebastien Bacher
Modified: 2012-03-28 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main: Fix remote option parsing (1013 bytes, patch)
2012-03-28 12:03 UTC, Bastien Nocera 		committed Details | Review

Description Sebastien Bacher 2012-02-03 17:14:54 UTC 
Using totem 3.3.4:

- start playing a video in totem
- run totem --pause on a command line -> the video pauses
- run totem --play on a command line

the video should resume playing but it doesn't
Comment 1 Bastien Nocera 2012-03-28 12:03:20 UTC 
Created attachment 210775 [details] [review]
main: Fix remote option parsing

When calling a function remotely for the second time, we were
inheriting the options from the first call. Eg. --pause followed by
--play would play and pause instantly the second time.
Comment 2 Philip Withnall 2012-03-28 14:05:17 UTC 
Review of attachment 210775 [details] [review]:

Fixes the problem for me.

::: src/totem.c
@@ +200,3 @@
 
+	/* Reset the options, if they were used before */
+	memset (&optionstate, 0, sizeof(optionstate));

Missing space after ‘sizeof’, if it matters.
Comment 3 Bastien Nocera 2012-03-28 15:21:50 UTC 
Comment on attachment 210775 [details] [review]
main: Fix remote option parsing

Committed with the white space fix.