GNOME Bugzilla – Bug 669289
gnotravex: Crashes with GTK 3.3.12
Last modified: 2012-02-05 05:59:13 UTC
The app menu API changed again This requires GTK 3.3.11
Created attachment 206668 [details] [review] gnotravex: Support the latest GTK app menu changes
Please add translatable="yes" to label attributes to fix internationalization. Also intltool have a problem with ' apostrophes, so it's better to use " instead.
Thanks for looking at this. Apostrophes where? Are you saying I need to convert all the ' to " and the " to ' in the menu section? By the way, this code is basically the same format as is found in the sample code at http://developer.gnome.org/gtk3/3.3/GtkApplication.html
(In reply to comment #3) > Thanks for looking at this. Apostrophes where? Are you saying I need to convert > all the ' to " and the " to ' in the menu section? > Yes. intltool expects translatable="yes" and refuses translatable='yes'. > By the way, this code is basically the same format as is found in the sample > code at http://developer.gnome.org/gtk3/3.3/GtkApplication.html This code is wrong, I'll file a bug about it. Unfortunately, even with translatable="yes" those string don't appear in PO files. Maybe you could put XML code in separate file, like gnome-contacts successfully does?
Sure, I can update the patch to move the app menu to a separate ui file. That would get rid of all the extra quotation marks and + signs which are annoying and easy to make mistakes. Thanks!
Created attachment 206727 [details] [review] gnotravex: Support the latest GTK app menu changes The app menu API changed again (requires GTK 3.3.11) Move appmenu UI code to separate UI/gresources file (requires glib 2.31.10)
Actually, I can't get builder add_from_resource to work. I did look at gnome-contacts and saw it uses a custom vapi, but that's beyond my experience. http://git.gnome.org/browse/gnome-contacts/tree/vapi/custom.vapi
Maybe this commit http://git.gnome.org/browse/gnome-contacts/commit/?id=b95c9c928345fba18c1d25a2d576f0c3951a5bf2 helps in any way. It's the one that introduced app menu from resources in gnome-contacts.
Created attachment 206732 [details] [review] gnotravex: Support the latest GTK app menu changes The app menu API changed again (requires GTK 3.3.11) Move appmenu UI code to separate UI/gresources file (requires glib 2.31.10)
Created attachment 206789 [details] [review] Rebase with current trunk gnotravex: Support the latest GTK app menu changes The app menu API changed again (requires GTK 3.3.11) Move appmenu UI code to separate UI/gresources file (requires glib 2.31.10)
Hi, I've pushed the core changes in this patch, but dropped the hard requirement on the latest GTK, dropped the resources changes (this should be in a separate bug). Thanks.