After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669191 - Address book dialog has incorrect default size
Address book dialog has incorrect default size
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
3.2.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-02-01 19:02 UTC by Marc Deslauriers
Modified: 2012-05-03 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot displaying the problem (31.30 KB, image/png)
2012-02-01 19:02 UTC, Marc Deslauriers 		  Details
patch to set a reasonable default size (1.43 KB, patch)
2012-02-01 19:06 UTC, Marc Deslauriers 		none Details | Review
try to guesstimate a default size to use for the name_selector_dialog (1.87 KB, patch)
2012-02-02 06:07 UTC, Mathieu Trudel-Lapierre 		committed Details | Review

Description Marc Deslauriers 2012-02-01 19:02:56 UTC 
Created attachment 206585 [details]
screenshot displaying the problem

When attempting to pick a recipient from the address book, the dialog that pops up is too small, only displaying the first contact in the list. I have to manually resize the window every single time to get it to show more than one contact. Also, it's not obvious that there are more buttons that aren't being displayed. See attached screenshot.

Downstream bug report:
https://bugs.launchpad.net/ubuntu/+source/evolution-data-server/+bug/906872
Comment 1 Marc Deslauriers 2012-02-01 19:06:40 UTC 
Created attachment 206586 [details] [review]
patch to set a reasonable default size
Comment 2 Mathieu Trudel-Lapierre 2012-02-02 06:06:09 UTC 
I looked at this problem on my side as well. The problem I see with this is that the default size used to be set to 512, and that was dropped (presumably as part of a fix for netbooks with tiny resolutions -- see http://git.gnome.org/browse/evolution-data-server/commit/?id=b06dbcfab9d5dbd0ca8d7979472010ce2aca6248)

I got to a slightly different fix that I hope would cover such a case as well (though it's kind of fugly). See attached patch.
Comment 3 Mathieu Trudel-Lapierre 2012-02-02 06:07:14 UTC 
Created attachment 206603 [details] [review]
try to guesstimate a default size to use for the name_selector_dialog
Comment 4 Milan Crha 2012-05-03 09:55:57 UTC 
Thanks for a bug report and patches. I'll go with Mathieu's, because it's more general and covers those small screens.
Comment 5 Milan Crha 2012-05-03 10:02:23 UTC 
Created commit 816fc40 in eds master (3.5.2+)
Created commit 4b4db0b in eds gnome-3-4 (3.4.2+)