After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669177 - Show who changed the subject.
Show who changed the subject.
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-01 14:29 UTC by Will Thompson
Modified: 2012-04-05 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Chat: show who changed the subject (4.00 KB, patch)
2012-02-01 14:30 UTC, Will Thompson 		reviewed Details | Review
Chat: show who changed the subject (3.79 KB, patch)
2012-02-01 17:30 UTC, Will Thompson 		committed Details | Review

Description Will Thompson 2012-02-01 14:29:39 UTC 
Empathy doesn't show who is responsible for the subject changing. I have a little patch coming up which makes it do this.
Comment 1 Will Thompson 2012-02-01 14:30:45 UTC 
Created attachment 206574 [details] [review]
Chat: show who changed the subject
Comment 2 Guillaume Desmottes 2012-02-01 15:09:59 UTC 
Review of attachment 206574 [details] [review]:

Looks good, just a comment which is a bit miss leading.

::: libempathy/empathy-tp-chat.c
@@ +612,1 @@
 	if (subject != NULL) {

actor could be defined in this block.

@@ +616,3 @@
+		/* If the actor is included with this update, use it;
+		 * otherwise, clear it to avoid showing stale information.
+		 * Why might it not be included? When you join an IRC channel,

Comment claims that the actor is cleared if not incuded but the code doesn't seem to do that.
Comment 3 Will Thompson 2012-02-01 17:30:39 UTC 
Created attachment 206581 [details] [review]
Chat: show who changed the subject
Comment 4 Will Thompson 2012-02-01 17:30:52 UTC 
Comment on attachment 206574 [details] [review]
Chat: show who changed the subject

You're quite right. I didn't actually finish changing the patch.
Comment 5 Guillaume Desmottes 2012-02-02 09:51:04 UTC 
Review of attachment 206581 [details] [review]:

++
Comment 6 Will Thompson 2012-04-05 10:34:37 UTC 
This was released in 3.3.5.