After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669131 - Bookmarks and History search entry uses wrong clear icon
Bookmarks and History search entry uses wrong clear icon
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-31 19:13 UTC by William Jon McCann
Modified: 2012-02-07 20:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (15.15 KB, image/png)
2012-01-31 19:15 UTC, William Jon McCann 		  Details
ephy-search-entry: use symbolic clear icon (1.27 KB, patch)
2012-02-03 06:10 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description William Jon McCann 2012-01-31 19:13:09 UTC 
Bookmarks and History search entry uses the color broom icon for clearing the entry. It should use the symbolic version.
Comment 1 William Jon McCann 2012-01-31 19:15:03 UTC 
Created attachment 206545 [details]
screenshot
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-02-03 06:10:59 UTC 
Created attachment 206669 [details] [review]
ephy-search-entry: use symbolic clear icon

Instead of gtk+ stock icon, use the symbolic version.  Respects LTR/RTL.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-02-03 06:12:38 UTC 
Review of attachment 206669 [details] [review]:

::: lib/widgets/ephy-search-entry.c
@@ +154,3 @@
+					   GTK_ENTRY_ICON_SECONDARY,
+					   ltr ? "edit-clear-symbolic" :
+					         "edit-clear-rtl-symbolic");

Is there API for this? Because it feels a bit weird.

Specially considering the rtl/ltr thing.
Comment 4 Xan Lopez 2012-02-07 10:19:22 UTC 
Review of attachment 206669 [details] [review]:

I suppose since it's using the icon name directly RTL support cannot be automatic? This is good enough for now though.

::: lib/widgets/ephy-search-entry.c
@@ +150,2 @@
 	entry->priv = EPHY_SEARCH_ENTRY_GET_PRIVATE (entry);
+	ltr = (gtk_widget_get_default_direction () == GTK_TEXT_DIR_LTR);

Don't really need the parenthesis here.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2012-02-07 20:25:17 UTC 
Done. Thanks :-)

Attachment 206669 [details] pushed as 0bcf4b4 - ephy-search-entry: use symbolic clear icon