After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669130 - New Window defaults to page with stop icon showing
New Window defaults to page with stop icon showing
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-31 19:11 UTC by William Jon McCann
Modified: 2012-02-09 11:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (10.95 KB, image/png)
2012-01-31 19:11 UTC, William Jon McCann 		  Details
ephy-shell: handle new tabs for NULL addresses (1.20 KB, patch)
2012-02-09 07:49 UTC, Diego Escalante Urrelo (not reading bugmail) 		reviewed Details | Review
ephy-shell: load home page in new windows (826 bytes, patch)
2012-02-09 10:29 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description William Jon McCann 2012-01-31 19:11:44 UTC 
Created attachment 206544 [details]
screenshot

When I do New Window in the menu I get a new browser window that has the stop button showing.
Comment 1 Xan Lopez 2012-02-01 12:13:58 UTC 
True, really odd. A quick debugging shows that on New window ephy thinks about:blank is loading, but on new tab doesn't.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 07:49:24 UTC 
Created attachment 207161 [details] [review]
ephy-shell: handle new tabs for NULL addresses

When calling ephy_shell_new_tab() with @address = NULL,
ephy_shell_new_tab_full() will receive a NULL @request.

This means that the tab is an empty WebKitWebView with status
WEBKIT_LOAD_PROVISIONAL.

Despite having the same visual outcome, it is more helpful to our signal
handlers to explicitely load "about:blank".
Comment 3 Xan Lopez 2012-02-09 09:34:15 UTC 
Review of attachment 207161 [details] [review]:

This code is fairly hairy (unfortunately), so I'd rather not change this without making sure it won't break anything else and, ideally, having some test coverage. Seems to me the trivial way to fix things (thanks for figuring it out) is to make New Window open about:blank, so let's just do that.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 10:29:09 UTC 
Created attachment 207170 [details] [review]
ephy-shell: load home page in new windows

Fixes the uncertain loading state of new windows.

==

Time capsule FIXME: ephy-shell sucks, needs cleanup.
Comment 5 Xan Lopez 2012-02-09 10:40:26 UTC 
Review of attachment 207170 [details] [review]:

Go!
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 11:12:00 UTC 
Comment on attachment 207170 [details] [review]
ephy-shell: load home page in new windows

Done!

Attachment 207170 [details] pushed as 93f655b - ephy-shell: load home page in new windows
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 11:12:30 UTC 
Damn you git-bz.