GNOME Bugzilla – Bug 669129
blank page drag icon is odd
Last modified: 2013-12-12 21:26:14 UTC
Created attachment 206543 [details] screenshot There are a few weird things about the blank page drag icon. * Odd that it is draggable at all * When I drop it on the URL location bar I get a weird result - about:blank and some unicode thingy * Weird that it has a tooltip when dragging it * the page suggestions after the drag are odd too
Created attachment 206674 [details] [review] ephy-location-entry: no need to set icons activatable Icons are activatable by default in GtkEntry. No need to reiterate that. = Found this while poking the widget for solutions.
Created attachment 206675 [details] [review] ephy-location-entry: disable icon drag for blank pages If the address being set by ephy_location_entry_set_location is NULL or about:blank, the entry will disable dragging for the GTK_ENTRY_ICON_PRIMARY icon. It is enabled by default on widget construction. = I'm a bit unsure if this is the best way, or if I should rather create a get/set for a ::drag-enabled property or something. If I added a property, I would use it in ephy-window.c to sync it with the ::is-blank property of EphyWebView. OTOH, ephy-location-entry.c already handles some about:blank special casing, although it is a more understandable case. What do you think?
Review of attachment 206674 [details] [review]: *Actually*. I think it's odd we mark the security lock as activatable right now, since it does nothing. So disable it for the secondary icon?
Review of attachment 206675 [details] [review]: The new designs seem to lean towards dropping the favicon in almost all cases (https://github.com/gnome-design-team/gnome-mockups/blob/master/web/url-entry.png). Perhaps we should just do that instead of spinning our wheels here.
(In reply to comment #4) > Review of attachment 206675 [details] [review]: > > The new designs seem to lean towards dropping the favicon in almost all cases > (https://github.com/gnome-design-team/gnome-mockups/blob/master/web/url-entry.png). > Perhaps we should just do that instead of spinning our wheels here. Uhm. Ok. Does not look bad. I would say we hold this patch until there's a final design for the location entry then.
(In reply to comment #3) > Review of attachment 206674 [details] [review]: > > *Actually*. I think it's odd we mark the security lock as activatable right > now, since it does nothing. So disable it for the secondary icon? It would make the @lock-clicked signal useless.
(In reply to comment #6) > > *Actually*. I think it's odd we mark the security lock as activatable right > > now, since it does nothing. So disable it for the secondary icon? > > It would make the @lock-clicked signal useless. Well, it's already useless, because it's not used. I think it's wrong to allow the icon to be clicked if nothing is going to happen.
Comment on attachment 206675 [details] [review] ephy-location-entry: disable icon drag for blank pages No longer applies cleanly to master.
Created attachment 263993 [details] [review] ephy-location-entry: disable icon drag for blank pages If the address being set by ephy_location_entry_set_location is NULL or about:blank, the entry will disable dragging for the GTK_ENTRY_ICON_PRIMARY icon. It is enabled by default on widget construction.
Review of attachment 263993 [details] [review]: Looks good.
Attachment 206674 [details] pushed as ad221ab - ephy-location-entry: no need to set icons activatable Attachment 263993 [details] pushed as e450a23 - ephy-location-entry: disable icon drag for blank pages