GNOME Bugzilla – Bug 669039
gstrtspconnection: new data may get sent even-though there is a queued message in the GstRTSPWatch
Last modified: 2012-02-17 14:46:54 UTC
Created attachment 206443 [details] [review]
only send new data if there are no queued messages
gst_rtsp_watch_write_data () will not check if there is already queued message in 'watch->write_data'.
The exact problem that i have noticed is that the gst-rtsp-server sometimes sends an RTSP data in the middle of an RTP packet when tunneling over HTTP and the bandwidth of the network is too low.
Attaching also a small patch which solves the problem.
Nice catch, thanks for the patch!
Author: Ognyan Tonchev <email@example.com>
Date: Mon Jan 30 15:55:26 2012 +0100
rtspconnection: only send new data immediately if there are no queued messages
Even if watch->messages->length is 0 there may still be some
data from a message that was only written partially at the
previous attempt stored in watch->write_data, so check for
that as well. We don't want to write data into the middle
of another message, which could happen when there wasn't