After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668998 - Consistent UI for saving Contacts like in Events/Tasks/Memos
Consistent UI for saving Contacts like in Events/Tasks/Memos
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
3.2.x (obsolete)
Other Linux
: Normal trivial
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-01-30 09:16 UTC by Nick Jenkins
Modified: 2012-04-27 01:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo patch (1.91 KB, patch)
2012-04-26 12:16 UTC, Milan Crha
committed Details | Review

Description Nick Jenkins 2012-01-30 09:16:03 UTC
When creating a new contact, mail, memo, task, or calendar item, the way of saving that new item should be consistent throughout.

However in Evo 3.2.2, Contacts are currently the odd one out, and are inconsistent with the rest of Evo's interface, in at least 3 different ways:
* Pressing Enter after entering a contact's full name will save the contact. No other component does this. In any other component, pressing Enter after finishing typing in a field will not save, and instead does nothing.
* To save in mail/memos/tasks/calendar, you must press ctrl-s, or click the "save" button. But in Contacts, ctrl-s is completely ignored.
* In mail/memos/tasks/calendar, there is a "Save" button. In Contacts, the equivalent is labelled just as "OK".

Requesting that Enter behaves consistently, that ctrl-s always works, and that the word "Save" be used consistently.
Comment 1 Milan Crha 2012-04-26 12:16:04 UTC
Created attachment 212877 [details] [review]
evo patch

for evolution;

Why not. I thought it'll not be that trivial, but it turned out it is. You even can apply this patch to the same files in /usr/share/evolution/X.Y/ui and your evolution will do it too.
Comment 2 Milan Crha 2012-04-26 12:17:45 UTC
Created commit 93e5656 in evo master (3.5.1+)
Comment 3 Nick Jenkins 2012-04-27 01:56:38 UTC
Most appreciated - thank you!