After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668965 - Memory leak when parsing fails for a child element of a Canvas
Memory leak when parsing fails for a child element of a Canvas
Status: RESOLVED FIXED
Product: libgxps
Classification: Platform
Component: general
0.2.x
Other Linux
: Normal minor
: ---
Assigned To: libgxps maintainers
libgxps maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-29 18:27 UTC by Jason Crain
Modified: 2012-01-30 12:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add error handler to canvas GMarkupParser (1.16 KB, patch)
2012-01-29 18:27 UTC, Jason Crain 		committed Details | Review

Description Jason Crain 2012-01-29 18:27:22 UTC 
Created attachment 206366 [details] [review]
add error handler to canvas GMarkupParser

A GXPSCanvas struct is leaked when parsing fails for a child element of a Canvas.

Example:

<Canvas>
  <Canvas.RenderTransform>
    <invalid />
  </Canvas.RenderTransform>
</Canvas>

Parsing is aborted when invalid data is encountered and cleanup code is not run.  This adds a error handler to the canvas GMarkupParser to free the struct on error.
Comment 1 Carlos Garcia Campos 2012-01-30 12:59:19 UTC 
Review of attachment 206366 [details] [review]:

Pushed! Thank you