After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668951 - Fix warnings when weak_unreffing a finalized object
Fix warnings when weak_unreffing a finalized object
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-29 12:27 UTC by Tristan Van Berkom
Modified: 2012-02-06 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix the warning (1.97 KB, patch)
2012-01-29 12:28 UTC, Tristan Van Berkom
committed Details | Review

Description Tristan Van Berkom 2012-01-29 12:27:40 UTC
Fixed these warnings by calling clutter_state_remove_key_internal() directly
instead of going through clutter_state_remove_key() which sets the inert flag
to FALSE implicitly.

Also fixed up the loop a little (removed one of the unneeded goto statements).


Stack trace from the g_log warning message:
  • #0 g_logv
    at gmessages.c line 765
  • #1 g_log
    at gmessages.c line 792
  • #2 clutter_state_key_free
    at ./clutter-state.c line 389
  • #3 clutter_state_remove_key_internal
    at ./clutter-state.c line 449
  • #4 clutter_state_remove_key
    at ./clutter-state.c line 1363
  • #5 clutter_state_remove_key_internal
    at ./clutter-state.c line 459
  • #6 object_disappeared
    at ./clutter-state.c line 478
  • #7 weak_refs_notify
    at gobject.c line 2454
  • #8 g_object_run_dispose
    at gobject.c line 1051
  • #9 clutter_actor_destroy

Comment 1 Tristan Van Berkom 2012-01-29 12:28:34 UTC
Created attachment 206350 [details] [review]
Patch to fix the warning 

Previous attach failed since I forgot to provide a description text...
Comment 2 Emmanuele Bassi (:ebassi) 2012-02-06 15:44:00 UTC
thanks for the patch; pushed to master