After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668907 - Allow for cropping of tablet area
Allow for cropping of tablet area
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Peter Hutterer
Control-Center Maintainers
Depends on: 675870
Blocks:
 
 
Reported: 2012-01-28 12:51 UTC by Bastien Nocera
Modified: 2012-06-11 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (4.42 KB, patch)
2012-05-11 12:30 UTC, Olivier Fourdan
needs-work Details | Review
Updated patch (5.96 KB, patch)
2012-05-23 12:51 UTC, Olivier Fourdan
none Details | Review
Screenshot (13.71 KB, image/png)
2012-05-23 12:52 UTC, Olivier Fourdan
  Details
Updated patch (6.11 KB, patch)
2012-06-06 08:21 UTC, Olivier Fourdan
accepted-commit_now Details | Review
Updated screenshot (17.21 KB, image/png)
2012-06-06 08:23 UTC, Olivier Fourdan
  Details

Description Bastien Nocera 2012-01-28 12:51:59 UTC
From http://www.youtube.com/watch?v=607uIdBmozU&feature=youtu.be

"
is there a way to setup the mapping of the tablet ; let say to get correct proportions between a squary tablet and a 16:10 screen ? ( cropping a part of the tablet area ) . The feature is often named 'force proportion' ?
"
Comment 1 Peter Hutterer 2012-01-29 04:40:43 UTC
The Tablet Area property can be used for that. We use it for calibration (on built-in tablets) but for standalone tablets it can be used to cut the valid area of the tablet down to whatever size. Jason had a patch to add this feature to xsetwacom. see http://old.nabble.com/RFC%3A--PATCH-4-4--Add-ability-to-match-input-aspect-ratio-to-the-current-output-ratio-p32551993.html
(was the first one I found). The same code can be used by GNOME.
Comment 2 Olivier Fourdan 2012-05-11 12:30:34 UTC
Created attachment 213862 [details] [review]
Proposed patch

Patch to add the UI option in the Wacom mapping panel.
Comment 3 Bastien Nocera 2012-05-18 10:10:17 UTC
Review of attachment 213862 [details] [review]:

::: panels/wacom/cc-wacom-mapping-panel.c
@@ +284,3 @@
 
+	/* Keep ratio checkbox */
+	priv->keep_aspect = gtk_check_button_new_with_label ("Adjust panel area to match aspect ratio");

Problably needs to be a switch instead of a checkbox, and the label will need checking.
Comment 4 Olivier Fourdan 2012-05-23 12:51:30 UTC
Created attachment 214756 [details] [review]
Updated patch

Update patch to use a switch and a different label
Comment 5 Olivier Fourdan 2012-05-23 12:52:21 UTC
Created attachment 214757 [details]
Screenshot

Screenshot of the dialog with patch from comment #4
Comment 6 Bastien Nocera 2012-05-23 15:25:40 UTC
Jakub mentioned using "Keep aspect ratio (letterbox)" instead.
Comment 7 Olivier Fourdan 2012-06-06 08:21:28 UTC
Created attachment 215712 [details] [review]
Updated patch

Updated label and dialog as  per comment #6 and border width set to 12 as per GNOME HIG.
Comment 8 Olivier Fourdan 2012-06-06 08:23:20 UTC
Created attachment 215713 [details]
Updated screenshot

Screenshot with patch from attachment #215712 [details]
Comment 9 Bastien Nocera 2012-06-11 14:29:49 UTC
Review of attachment 215712 [details] [review]:

Looks good.
Comment 10 Olivier Fourdan 2012-06-11 15:55:40 UTC
committed