After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668845 - [0.11] deinterlacer needs porting
[0.11] deinterlacer needs porting
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.11.x
Other Linux
: Normal blocker
: 0.11.x
Assigned To: Robert Swain
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-27 15:02 UTC by Christian Fredrik Kalager Schaller
Modified: 2012-09-24 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christian Fredrik Kalager Schaller 2012-01-27 15:02:55 UTC 
There is currently no good deinterlacer plugin for 0.11/1.0. The deinterlacer plugin needs porting.
Comment 1 Tim-Philipp Müller 2012-07-04 09:49:28 UTC 
I've made a start on this.
Comment 2 Bastien Nocera 2012-07-17 09:45:28 UTC 
This is necessary for deinterlaced streams to be played back in playbin. We currently get a warning about the element being missing, without any ways to actually fix it.
Comment 3 Tim-Philipp Müller 2012-07-17 12:48:11 UTC 
I've committed this for the time being, but intend to revert it again once deinterlace is ported:

 commit 0615794300234e3efbcb49a524efdee11171ab4c
 Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
 Date:   Tue Jul 17 13:45:13 2012 +0100

    playbin: use avdeinterlace for deinterlacing until deinterlace is ported
Comment 4 Tim-Philipp Müller 2012-07-17 12:49:57 UTC 
Rob Swain has been doing some work on this as well in

 http://cgit.collabora.com/git/user/robswain/gst-plugins-base/
 http://cgit.collabora.com/git/user/robswain/gst-plugins-good/

(but it doesn't compile yet, so just mentioning it for completeness).
Comment 5 Robert Swain 2012-07-19 23:01:55 UTC 
It compiles and works now, as long as upstream is providing buffers with their state identified appropriately using the new buffer flag where necessary. I'll try to get it committed tomorrow. I also have a patch for interlace to make it apply the correct caps/flags.
Comment 6 Robert Swain 2012-07-19 23:02:42 UTC 
Assign to me.
Comment 7 Robert Swain 2012-07-20 21:36:57 UTC 
commit eac172c43386042f1da6cb608ab5b99ca169a24e
Author: Robert Swain <robert.swain@collabora.co.uk>
Date:   Thu Jul 19 14:55:45 2012 +0200

    deinterlace: Port to 1.0
    
    This requires the additional INTERLACED buffer flag recently added to
    -base

Any bugs can be opened as new issues, but it works now.