After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668757 - wrong method description in introspect-collection.xml
wrong method description in introspect-collection.xml
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: keyring files
unspecified
Other Linux
: Normal minor
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-01-26 16:33 UTC by schwarz
Modified: 2012-01-27 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch introspect-collection.xml (508 bytes, patch)
2012-01-27 08:47 UTC, schwarz
none Details | Review

Description schwarz 2012-01-26 16:33:38 UTC
Ubuntu with Gnome-keyring 2.92.92.is.2.31.91-0ubuntu4 and libgnome-keyring0 2.31.92-0ubuntu1


Introspection on the Collection path gives:

$ dbus-send --session --type=method_call --print-reply --dest=org.freedesktop.secrets /org/freedesktop/secrets/collection/login org.freedesktop.DBus.Introspectable.Introspect
...
	<interface name="org.freedesktop.Secrets.Collection">
		<method name="SearchItems">
			<arg name="attributes" type="a{ss}" direction="in"/>
			<arg name="results" type="ao" direction="out"/>
		</method>
...

When I use this interface, my call fails with a "wrong return type" error.

I fixed this with the following XML for Collection:
	<interface name="org.freedesktop.Secrets.Collection">
		<method name="SearchItems">
			<arg name="attributes" type="a{ss}" direction="in"/>
			<arg name="unlocked" type="ao" direction="out"/>
			<arg name="locked" type="ao" direction="out"/>
		</method>

the same as the "org.freedesktop.Secrets.Service" interface.

Patch is attached

Best regards
Comment 1 schwarz 2012-01-27 08:47:48 UTC
Created attachment 206245 [details] [review]
patch introspect-collection.xml
Comment 2 Stef Walter 2012-01-27 13:49:23 UTC
Thanks. The patch didn't apply to git master, but I fixed the appropriate spot.