After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668750 - valac adds g_thread_init() for apps compiled with --thread
valac adds g_thread_init() for apps compiled with --thread
Status: RESOLVED DUPLICATE of bug 692218
Product: vala
Classification: Core
Component: Code Generator
0.14.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-26 15:23 UTC by Mathieu Trudel-Lapierre
Modified: 2016-10-10 07:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
don't generate calls to g_thread_init() (4.46 KB, patch)
2012-01-26 15:23 UTC, Mathieu Trudel-Lapierre
needs-work Details | Review

Description Mathieu Trudel-Lapierre 2012-01-26 15:23:04 UTC
Created attachment 206191 [details] [review]
don't generate calls to g_thread_init()

If an application is compiled with --thread and calls Gtk.init(), the valac compiler adds a call to g_thread_init(), which results in a compilation failure on distros using recent versions of glib (and is unnecessary even on relatively old versions).

This appears to affect at least 0.14 and 0.10, so I'd bet 0.12 is also affected ;) 0.15/0.15 do not appear to be affected by this issue.

I'm attaching a patch that covers this for 0.14.
Comment 1 Luca Bruno 2012-01-26 15:27:20 UTC
Review of attachment 206191 [details] [review]:

Thanks for the patch. The fact that has been deprecated it doesn't mean old code isn't using it. The patch must take in consideration the targeted glib from which it's been deprecated.
Comment 2 Rico Tzschichholz 2016-10-10 07:42:01 UTC

*** This bug has been marked as a duplicate of bug 692218 ***