After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668736 - Incorrect argument is passed for page index when command is spawned
Incorrect argument is passed for page index when command is spawned
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-26 12:49 UTC by Ron Yorston
Modified: 2012-02-05 11:34 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2

Attachments
Fix page index argument when command is spawned (754 bytes, patch)
2012-01-26 12:49 UTC, Ron Yorston 		none Details | Review
Second attempt (816 bytes, patch)
2012-01-26 13:23 UTC, Ron Yorston 		committed Details | Review

Description Ron Yorston 2012-01-26 12:49:01 UTC 
Created attachment 206180 [details] [review]
Fix page index argument when command is spawned

The code which generates a command line when evince wants to spawn another instance of itself is wrong.  It uses the --page-label argument when it should use --page-index.
Comment 1 Ron Yorston 2012-01-26 13:23:08 UTC 
Created attachment 206183 [details] [review]
Second attempt

It's not just the option that's wrong, the value is incorrect too.  Internally page indices are zero-based but on the command line they start from one.
Comment 2 Carlos Garcia Campos 2012-02-05 11:34:14 UTC 
Review of attachment 206183 [details] [review]:

Good catch!, pushed to git master, thank you.