After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668693 - Improvements to Aqbanking transaction dialog
Improvements to Aqbanking transaction dialog
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Import - AqBanking
git-master
Other Linux
: Normal enhancement
: ---
Assigned To: Christian Stimming
Christian Stimming
Depends on:
Blocks:
 
 
Reported: 2012-01-25 21:16 UTC by Johannes Schmid
Modified: 2018-06-29 23:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
aqbanking: Added API docs for transaction (2.63 KB, patch)
2012-01-25 21:17 UTC, Johannes Schmid
committed Details | Review
aqbanking: Big code cleanup in transaction dialog (19.56 KB, patch)
2012-01-25 21:17 UTC, Johannes Schmid
committed Details | Review
aqbanking: Improve transaction UI (74.02 KB, patch)
2012-01-25 21:17 UTC, Johannes Schmid
committed Details | Review

Description Johannes Schmid 2012-01-25 21:16:11 UTC
A couple of improvements made to the aqbanking transaction dialog:
1) Trivial api docs
2) Code clean-up (sorry...)
3) Don't allow to click execute until values are ok

First try with git-bz - might end up horrible...
Comment 1 Johannes Schmid 2012-01-25 21:17:21 UTC
Created attachment 206131 [details] [review]
aqbanking: Added API docs for transaction
Comment 2 Johannes Schmid 2012-01-25 21:17:24 UTC
Created attachment 206132 [details] [review]
aqbanking: Big code cleanup in transaction dialog
Comment 3 Johannes Schmid 2012-01-25 21:17:27 UTC
Created attachment 206133 [details] [review]
aqbanking: Improve transaction UI

* Use expander to show/hide templates
* Disable execute button as long as field values are incorrect
* Use icons and tooltips in entries to indicate that an incorrect value was inserted
Comment 4 Christian Stimming 2012-01-26 10:58:41 UTC
Comment on attachment 206131 [details] [review]
aqbanking: Added API docs for transaction

All code looks fine.

You're using git - me too. Can we find an easier way to transport the patches to my side? How about a github repo where you push your patches and I pull from there?
Comment 5 Johannes Schmid 2012-01-26 21:14:20 UTC
SVN was a bit inconvenient after having used git for so long. But good to remember those good old days with DVCS ;)

Anyway, I pushed the stuff to github:
https://github.com/jhs-s/gnucash-aqplus
Comment 6 Christian Stimming 2012-01-28 22:13:28 UTC
r21901 - r21903, thanks a lot!

Feel free to push more changes on github. Fetching from there is indeed much much easier than downloading here from bugzilla.
Comment 7 Christian Stimming 2012-01-28 22:24:40 UTC
Hm... the icons are very nice as well as the reaction on the entered account number.

However, the "amount" entry field needs further work. I cannot edit the amount as before: When pressing "backspace", the comma appears and I cannot get rid of it. After some more typing, the amount field contains the value "0,00" and I cannot change it anymore: Neither pressing backspace deletes any of the digits, nor marking the full text and entering some other value works. The amount field is stuck at 0,00. Also, after opening a new transfer dialog, when typing "1,23" the behaviour is this: Typing the "1" gets a "1,00"; typing "," turns this into "0,00"; typing "2" gets "0,20"; typing "3" gets "0,23".

This is ubuntu 11.04; gtk-2.24.6; locale de_DE.UTF-8
Comment 8 Johannes Schmid 2012-01-29 11:16:38 UTC
Hi!

> However, the "amount" entry field needs further work. I cannot edit the amount
> as before: When pressing "backspace", the comma appears and I cannot get rid of
> it. After some more typing, the amount field contains the value "0,00" and I
> cannot change it anymore: Neither pressing backspace deletes any of the digits,
> nor marking the full text and entering some other value works. The amount field
> is stuck at 0,00. Also, after opening a new transfer dialog, when typing "1,23"
> the behaviour is this: Typing the "1" gets a "1,00"; typing "," turns this into
> "0,00"; typing "2" gets "0,20"; typing "3" gets "0,23".

I see the same but actually I don't think I changed anything on the amount entry code and I don't know how it works internally. If you want, I can replace it with a GtkSpinButton which is the widget I see most suitable for that job.

I fixed a compile warning in my repository that you still might want to look at.
Comment 9 Christian Stimming 2012-01-29 20:27:35 UTC
> but actually I don't think I changed anything on the amount entry code

You at least added the "changed" callback on that widget. I've disabled it for now, which makes the amount entry work again, even though it isn't checked directly. Feel free to find another (better) correction here.

By the way, please rebase your github master on top of the svn-trunk because that's what the svn-trunk needs for further svn commits. Thanks!
Comment 10 Johannes Schmid 2012-01-29 21:11:38 UTC
> You at least added the "changed" callback on that widget. I've disabled it for
> now, which makes the amount entry work again, even though it isn't checked
> directly. Feel free to find another (better) correction here.

I don't know the internal of the widget so I just worked around that for now by using "focus-out-event":

https://github.com/jhs-s/gnucash-aqplus/commit/623c72cf965130b4a0464f2a4e5bfc27782f06a9
 
> By the way, please rebase your github master on top of the svn-trunk because
> that's what the svn-trunk needs for further svn commits. Thanks!

Hmm, I don't use git-svn but only the github mirror (git://github.com/Gnucash/gnucash.git) and I sync with this. I only have a trunk branch, no master branch and no svn-trunk branch but I hope that doesn't cause to many problems for you.
Comment 11 Christian Stimming 2012-02-19 11:00:51 UTC
r22054, thanks a lot!
Comment 12 John Ralls 2018-06-29 23:05:30 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=668693. Please update any external references or bookmarks.