GNOME Bugzilla – Bug 668653
Need a follow-up release to boxes 3.3.4
Last modified: 2016-03-31 13:55:09 UTC
Because of bug https://bugzilla.gnome.org/show_bug.cgi?id=668584 , latest Boxes release doesn't work with latest gtk+ release, which means we should do a release to fix that. Here are the patches I think we can pick for this release, though only the "Move set_app_menu to app.startup.connect_after" is really needed. 38c6b911dfc6bc may be a candidate too, but I'm afraid that by adding code changes we'll break more stuff and need a 3.4.4.2 so it feels safer to stay with these commits. The reason it's a 3.3.4.1 release and not a 3.3.5 release is that master depends on libvirt-glib git, so it cannot be released as is, so I branched off the 3.3.4 tag.
Created attachment 206077 [details] [review] Ship src/config.vapi in tarballs It's needed to regenerate the C files from the vala files so we should ship it in tarballs.
Created attachment 206078 [details] [review] Add missing cairo.vapi to EXTRA_DIST
Created attachment 206079 [details] [review] build: improve the build from vala https://bugzilla.gnome.org/show_bug.cgi?id=668104
Created attachment 206080 [details] [review] Enable vala when building from git autogen.sh is usually run when building from git and we don't have generated C files in git so enable vala from autogen.sh.
Created attachment 206081 [details] [review] Move set_app_menu to app.startup.connect_after Boxes fails to start with a current git snapshot of gtk/glib because set_app_menu is not called from the app startup function. This used to work when the menu stuff was still using dbus but broke when it switched to x properties. Here is some non-committed documentation about this: https://bugzilla.gnome.org/show_bug.cgi?id=668203 I'm attaching a patch that moves the menu to app startup. I've decided to put it into the startup directly as it was not part of setup_ui() before, but it might make sense to move it there (before creating the window). This fixes https://bugzilla.gnome.org/show_bug.cgi?id=668584
Created attachment 206082 [details] [review] Release 3.3.4.1
sounds good to me, I guess we can wait for zeeshan to give it a go too today
I wont be able to test anything for another few hours but last night I was getting constant crashes when trying to start Boxes after 'jhbuild build gtk+ gnome-themes-standard'. Most probably my environment is ****** but please test it and check if all wizard widgets look alright.
Look at your IRC :) 13:06 <@teuf> zeenix: git revert fe10b2c9662 in glib for your startup crash
All pushed