After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668652 - Do not show the titlebar when eog is maximized
Do not show the titlebar when eog is maximized
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: GNOME3.6
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-25 11:27 UTC by Claudio Saavedra
Modified: 2012-08-12 13:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do not show the titlebar when eog is maximized. (1.10 KB, patch)
2012-01-25 11:27 UTC, Claudio Saavedra
committed Details | Review

Description Claudio Saavedra 2012-01-25 11:27:42 UTC
We are doing this in ephy and we probably want it in eog too:

https://live.gnome.org/GnomeOS/Design/Whiteboards/WindowStates

I know some people will complain about the filenames, but we ought to
solve that somehow else. We need to reduce chrome.
Comment 1 Claudio Saavedra 2012-01-25 11:27:48 UTC
Created attachment 206076 [details] [review]
Do not show the titlebar when eog is maximized.

This is the default behavior for GNOME 3.4.
Comment 2 Felix Riemann 2012-01-28 10:48:03 UTC
Do you have a screenshot of how this looks?
I guess my local mutter version is not recent enough to show the effect.

If it makes more screen space available for the image it certainly is a nice idea.

Regarding the then hidden filenames, I think the properties dialog & sidebar + the tooltip in the collection should be enough places to find the filename.
Comment 3 Claudio Saavedra 2012-01-29 07:47:39 UTC
Sure! Here you are: http://people.gnome.org/~csaavedra/images/2012-01-29-eog.png
Comment 4 Felix Riemann 2012-01-29 10:39:26 UTC
Review of attachment 206076 [details] [review]:

(In reply to comment #3)
> Sure! Here you are:
> http://people.gnome.org/~csaavedra/images/2012-01-29-eog.png

Nice! Let's give it a try. :)
Comment 5 Claudio Saavedra 2012-01-29 10:49:03 UTC
Thanks!
# Bug 668652 - Do not show the titlebar when eog is maximized - NEW

Attachment 206076 [details] pushed as c93aa0b - Do not show the titlebar when eog is maximized.
Comment 6 ahatomastarday 2012-02-06 16:26:58 UTC
Shouldn't the menubar be also hidden and in fact replaced by a Shell-styled menu?
Comment 7 Claudio Saavedra 2012-02-06 18:53:18 UTC
Most likely yes, but that'll require a bit of extra time that I don't currently have :) We'll get there eventually.
Comment 8 Felix Riemann 2012-03-18 18:03:46 UTC
Reopening as per bug 671643, so we can take another look at it and test it during the 3.6 development cycle when all the necessary infrastructure works reliably (and fast).

We need to decide whether we want it or not and if it should be in by default or if it should be a plugin.
Comment 9 Felix Riemann 2012-08-12 13:20:21 UTC
It's hard to decide really.

Moved it into a plugin for now, so testing and evaluating is easier.

commit 42acca2c8daf8dafb1427ce44ac1d3a9d7101237
Author: Felix Riemann <>
Date:   Sun Aug 12 15:11:04 2012 +0200

    Add new plugin: Hide Titlebar
    
    This hides eog's titlebar when the window is maximized.
    The function is more or less parked in this plugin for now as it's unclear
    whether this would be a good default for eog.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=668652
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.