After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668614 - Change display mapping on "monitors-changed" event
Change display mapping on "monitors-changed" event
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-24 20:30 UTC by Bastien Nocera
Modified: 2012-06-11 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.83 KB, patch)
2012-05-14 09:47 UTC, Olivier Fourdan
none Details | Review
Updated patch (3.99 KB, patch)
2012-05-15 08:55 UTC, Olivier Fourdan
accepted-commit_now Details | Review
Updated patch (4.19 KB, patch)
2012-05-22 12:15 UTC, Olivier Fourdan
accepted-commit_now Details | Review

Description Bastien Nocera 2012-01-24 20:30:30 UTC
Otherwise we'd be pointing to the wrong monitor.
Comment 1 Olivier Fourdan 2012-05-14 09:47:12 UTC
Created attachment 213989 [details] [review]
Proposed patch

Patch to update the display mapping when the signal "monitors-changed" is received.
Comment 2 Olivier Fourdan 2012-05-15 08:55:50 UTC
Created attachment 214071 [details] [review]
Updated patch

Updated patch to use GnomeRRScreen instead of GdkScreen signals to get notified of rotation changes so that we can address bug 668547 using the same notification mechanism as well.
Comment 3 Bastien Nocera 2012-05-17 17:57:02 UTC
Review of attachment 214071 [details] [review]:

Looks good.

::: plugins/wacom/gsd-wacom-manager.c
@@ +1050,3 @@
+			continue;
+		}
+		manager->priv->rr_screens = g_slist_append (manager->priv->rr_screens, rr_screen);

Make it a GList and prepend instead.

@@ +1105,3 @@
         }
+
+	for (ls = p->rr_screens; ls != NULL; ls = ls->next)

And then l, not ls
Comment 4 Olivier Fourdan 2012-05-22 12:15:28 UTC
Created attachment 214649 [details] [review]
Updated patch

Updated patch taking into account comment 3
Comment 5 Bastien Nocera 2012-05-22 13:15:28 UTC
Review of attachment 214649 [details] [review]:

Looks good.
Comment 6 Olivier Fourdan 2012-06-11 13:08:14 UTC
Committed.