After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668599 - "Take a photo" shouldn't use record icon
"Take a photo" shouldn't use record icon
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 3.2
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-01-24 18:29 UTC by Bastien Nocera
Modified: 2013-11-07 23:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use symbolic icons for photo and video button (3.44 KB, patch)
2013-11-07 21:59 UTC, Rashi Aswani 		needs-work Details | Review
Use symbolic icons for photo and video button (3.44 KB, patch)
2013-11-07 22:24 UTC, Rashi Aswani 		none Details | Review
Use symbolic icons for photo and video button (2.28 KB, patch)
2013-11-07 23:17 UTC, Rashi Aswani 		committed Details | Review

Description Bastien Nocera 2012-01-24 18:29:39 UTC 
The record icon is associated with recording audio or video, not taking pictures. The icon should be something else.
Comment 1 Rashi Aswani 2013-11-07 21:59:19 UTC 
Created attachment 259224 [details] [review]
Use symbolic icons for photo and video button
Comment 2 David King 2013-11-07 22:06:40 UTC 
Review of attachment 259224 [details] [review]:

The icon changes look fine. Thanks for the patch, just a few comments about indentation.

::: data/cheese-main-window.ui
@@ +103,3 @@
                                 <child>
                                   <object class="GtkLabel" id="take_action_button_internal_label">
+			            <property name="label" translatable="yes">_Take a Photo</property>

This line should not be changed, as it is unrelated to your other changes. You should remove this change from the commit (and the patch).

@@ +151,3 @@
                                   <object class="GtkLabel" id="effects_toggle_button_internal_label">
+				   <property name="label" translatable="yes">_Effects</property>
+				    <property name="use_underline">True</property>

These two lines should not be changed, just like the other line.
Comment 3 Rashi Aswani 2013-11-07 22:24:52 UTC 
Created attachment 259228 [details] [review]
Use symbolic icons for photo and video button
Comment 4 Rashi Aswani 2013-11-07 23:17:01 UTC 
Created attachment 259232 [details] [review]
Use symbolic icons for photo and video button
Comment 5 David King 2013-11-07 23:23:21 UTC 
Comment on attachment 259232 [details] [review]
Use symbolic icons for photo and video button

Thanks for the corrected patch. I added some explanation to the commit message and pushed it to master as commit b1f41512c777cfc9ed1c3edaebcf6c17f7d06322.