After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668566 - GST_PLUGIN_DEFINE does not complain if there is invalid license
GST_PLUGIN_DEFINE does not complain if there is invalid license
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.x
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-24 12:03 UTC by Jan Spurny
Modified: 2012-07-15 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jan Spurny 2012-01-24 12:03:00 UTC
I just spent 2 days looking for a bug in a new gstreamer plugin. It was rejected and BLACKLISTED. I just couldn't figure out what was wrong.. I rewrote the damn thing 3 times, tried everything and it didn't work.
Because we haven't decided for a license, I put "TODO" in place of license type. I know it was my mistake, and I know that in documentation there is clearly said:

 The licence parameter must be one of:
   LGPL, GPL, QPL, GPL/QPL, MPL, BSD, MIT/X11, Proprietary, unknown.

but wouldn't be nice to print at least some warning or something that may give a hint about what's wrong?
I guess that may be just one line of code which may one day save some poor half-mad programmer like me a few days.
Comment 1 Vincent Penquerc'h 2012-01-26 18:47:33 UTC
A warnings should be printed, but it might be only on the first run, when the plugin is considered before being blacklisted.

Is a warning printed if you delete the ~/.gstreamer0.10/registry*bin file, then try to load your plugin again ? It is here, testing on a random plugin.

It would be nice to be able to tell why each plugin is blacklisted from an existing blacklist. There is a bug filed about this, I believe, though nothing has been done for it so far.
Comment 2 Jan Spurny 2012-01-26 19:32:08 UTC
My bad - the warning is there, it's even the first thing printed.. I'm a little ashamed that I didn't saw that. Sorry.
Comment 3 Vincent Penquerc'h 2012-01-26 20:40:01 UTC
No worries. As I said, it's easy to miss since it doesn't appear again after the plugin was blacklisted once.
I'll close this then, since there's an existing bug already about giving information about blacklisted plugins.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2012-07-15 18:35:49 UTC
FYI: other bug is https://bugzilla.gnome.org/show_bug.cgi?id=648010