After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668551 - Desktop often shown before lock screen when resuming from suspend or inactivity
Desktop often shown before lock screen when resuming from suspend or inactivity
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
3.2.x
Other Linux
: Normal major
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks: 668877
 
 
Reported: 2012-01-24 02:11 UTC by Adam Williamson
Modified: 2013-01-19 22:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Adam Williamson 2012-01-24 02:11:42 UTC
I'm on Fedora Rawhide, with mostly GNOME 3.3 packages now and gnome-screensaver-3.2.0-2.fc17.x86_64 .

I have dual heads - both Dell 20" 1920x1080 screens in portrait orientation.

Often, when I wake up from suspend or just come back from a timeout-induced screen lock, the monitors will show my desktop for a few seconds before fading out to the lock screen. Sometimes I can even interact with the desktop during this time, so this has security implications as well as simply being very bad polish.

I think this was mostly 'fixed' for a bit during F16 release time frame, but has since gotten worse again.
Comment 1 Ray Strode [halfline] 2012-01-24 18:34:01 UTC
how do you suspend it in the first place?
Comment 2 Ray Strode [halfline] 2012-01-24 18:44:51 UTC
if it's upower initiating the sleep then it gets screensaver 1 second to lock before suspending. That's racy, of course.  Especially since the lock fade is 1 second long.

It would be good if settings daemon could just-in-time inhibit suspend rather than racing against the clock.  That has security ramifications on multi-user systems too though.

dropping the fade out on explicit screen locks is the easiest way to mitigate this problem, but it's not fool proof.
Comment 3 Ray Strode [halfline] 2012-01-24 18:53:49 UTC
okay so the sleep is actually initiated from the g-s-d power plugin on lid close. that same plugin ties to the sleep-notify signal which is inherently racy.

I guess instead it should lock explicitly before calling Suspend.  This has a problem that if Suspend fails for security policy reasons, I guess, the screen will still lock, though.
Comment 4 Ray Strode [halfline] 2012-01-24 18:58:06 UTC
i'll push a commit to shorten the screensaver fade out but we should fix this in power plugin.  

(i'm taking a leap and assuming the answer to comment 1 is "close the lid")
Comment 5 Adam Williamson 2012-01-27 04:14:27 UTC
My system's actually a desktop, so I suspend it from the GNOME user menu.
Comment 6 Adam Williamson 2012-01-27 04:15:08 UTC
Comedically, the system fails to suspend with the new 3.3 kernel, so it's going to be harder to test this. Sigh. I'll try and dig out a 3.2 kernel if you need me to check anything.
Comment 7 Ray Strode [halfline] 2012-01-27 19:39:42 UTC
interesting, so screensaver must be returning from Lock() before it locks.
Comment 8 Ray Strode [halfline] 2012-01-27 19:51:19 UTC
Indeed,

        if (dbus_message_is_method_call (message, GS_SERVICE, "Lock")) {
                g_signal_emit (listener, signals [LOCK], 0);            
                return send_success_reply (connection, message);        
        }                                                               

we send the reply as soon as we fire off the machinery. we don't wait for it to finish.
Comment 9 Ray Strode [halfline] 2012-01-27 19:55:27 UTC
since there's two problems i've cloned this bug as bug 668877 to cover the screensaver half.

I'll leave this bug number for g-s-d
Comment 10 Richard Hughes 2012-09-03 08:48:53 UTC
I haven't seen this bug in a long time. Can we close the g-s-d bit now too?
Comment 11 Adam Williamson 2012-09-04 19:17:08 UTC
I was still seeing bad behaviour - or maybe it came back - on this system with F17, before I updated to F18. I'd get solid blue background. I think that may come down to interaction with revelation (the password manager app I run), though. revelation seems possibly to do something a bit odd with its unlock dialog.

I can't say what the status is on F18 right now because I've had the lock screen disabled for other reasons, though I may turn it back on soon.
Comment 12 Tobias Mueller 2013-01-19 19:59:56 UTC
Adam, any news here?
Comment 13 Adam Williamson 2013-01-19 22:31:04 UTC
Upgraded this laptop to F18 the other day and haven't seen any trouble since, so sure, we can probably close this out. Still have lock screen disabled on the desktop. If I ever turn it back on I'll check this out.