After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668502 - "No topic defined" displayed when reconnecting a private chat
"No topic defined" displayed when reconnecting a private chat
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.33.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-23 14:18 UTC by Guillaume Desmottes
Modified: 2012-01-24 12:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't display 'No topic defined' in private chats (895 bytes, patch)
2012-01-23 14:28 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review
don't display 'No topic defined' if topic are not supported (1.30 KB, patch)
2012-01-24 09:29 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-01-23 14:18:59 UTC 
- Start a chat with a contact
- Disconnect and then reconnect your network
- The chat window displays "No topic defined"

We don't care about this message, private chats can't have a topic anyway.
Comment 1 Guillaume Desmottes 2012-01-23 14:28:02 UTC 
Created attachment 205885 [details] [review]
don't display 'No topic defined' in private chats
Comment 2 Danielle Madeley 2012-01-23 22:08:14 UTC 
Review of attachment 205885 [details] [review]:

++
Comment 3 Danielle Madeley 2012-01-23 22:09:12 UTC 
(In reply to comment #0)

> We don't care about this message, private chats can't have a topic anyway.

Arguably they can, Google Talk does this when you reply to someone's email via chat.
Comment 4 Guillaume Desmottes 2012-01-24 09:29:27 UTC 
(In reply to comment #3)
> (In reply to comment #0)
> 
> > We don't care about this message, private chats can't have a topic anyway.
> 
> Arguably they can, Google Talk does this when you reply to someone's email via
> chat.

Ok, what about this patch then.
Comment 5 Guillaume Desmottes 2012-01-24 09:29:41 UTC 
Created attachment 205956 [details] [review]
don't display 'No topic defined' if topic are not supported
Comment 6 Danielle Madeley 2012-01-24 11:44:01 UTC 
Review of attachment 205956 [details] [review]:

++
Comment 7 Guillaume Desmottes 2012-01-24 12:24:35 UTC 
Bug 668502 - "No topic defined" displayed when reconnecting a private chat - NEW

Attachment 205956 [details] pushed as 6de7927 - don't display 'No topic defined' if topic are not supported